public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: benoit-lists@fb12.de
Cc: kuznet@ms2.inr.ac.ru, dada1@cosmosbay.com, cgf@redhat.com,
	andersg@0x63.nu, lkernel2003@tuxers.net,
	linux-kernel@vger.kernel.org, tobi@tobi.nu
Subject: Re: [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX
Date: Tue, 28 Jan 2003 12:34:13 -0800 (PST)	[thread overview]
Message-ID: <20030128.123413.51821993.davem@redhat.com> (raw)
In-Reply-To: <20030128201645.A29746@turing.fb12.de>

   From: Sebastian Benoit <benoit-lists@fb12.de>
   Date: Tue, 28 Jan 2003 20:16:45 +0100

   David S. Miller(davem@redhat.com)@2003.01.28 10:35:34 +0000:
   > Good set of debug checks would be the following:
   
   no output, i did 4 tests, everytime i was able to lock the ssh-connection
   within a few seconds. kernel 2.5.59 + your debug-patch.

Thanks for testing, how about this new patch at the end of this email?
Does it make the problem go away?

Alexey, most solid report is that 2.5.43-bk1 makes bug appear.
This is good because it sort of narrows things down.  What is
contained there in networking is:

1) initial stackable dst logic, should not cause problems
2) addition of UDP sendfile and ip_append_*() logic
3) fix to tcp_check_req() "fix" :-)  it only changes bahevior
   on connect so should not be a problem

I heavily, therefore, suspect #2 which is why I am poking around
in the tcp.c changes to change checksumming and copying semantics.

--- net/ipv4/tcp.c.~1~	Tue Jan 28 12:40:09 2003
+++ net/ipv4/tcp.c	Tue Jan 28 12:41:48 2003
@@ -1089,11 +1089,13 @@
 				if (!skb)
 					goto wait_for_memory;
 
+#if 0
 				/*
 				 * Check whether we can use HW checksum.
 				 */
 				if (sk->route_caps & (NETIF_F_IP_CSUM|NETIF_F_NO_CSUM|NETIF_F_HW_CSUM))
 					skb->ip_summed = CHECKSUM_HW;
+#endif
 
 				skb_entail(sk, tp, skb);
 				copy = mss_now;

  reply	other threads:[~2003-01-28 20:37 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-24 18:43 SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX David C Niemi
2003-01-24 20:29 ` David S. Miller
2003-01-24 20:46 ` lost
2003-01-24 21:15   ` Christopher Faylor
2003-01-25  2:00     ` SSH Hangs in 2.5.59 and 2.5.55 (TCP_NODELAY?) Christopher Faylor
2003-01-27 14:27 ` SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX David C Niemi
2003-01-27 18:06   ` David S. Miller
2003-01-27 18:11   ` David S. Miller
2003-01-27 18:28     ` Anders Gustafsson
2003-01-27 22:36       ` [TEST FIX] " David S. Miller
2003-01-28  2:25         ` lost
2003-01-28  2:57         ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, kuznet
2003-01-28  3:22           ` Christopher Faylor
2003-01-28  3:39         ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX Christopher Faylor
2003-01-28  3:55           ` kuznet
2003-01-28  7:08             ` dada1
2003-01-28 12:36               ` Sebastian Benoit
2003-01-28 14:09                 ` kuznet
2003-01-28 18:35                   ` David S. Miller
2003-01-28 19:16                     ` Sebastian Benoit
2003-01-28 20:34                       ` David S. Miller [this message]
2003-01-28 21:59                         ` Christopher Faylor
2003-01-28 22:12                         ` Sebastian Benoit
2003-01-28 23:21                           ` David S. Miller
2003-01-29  0:02                             ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, kuznet
2003-01-29  0:09                             ` kuznet
2003-01-29  0:46                               ` Sebastian Benoit
2003-01-29  4:12                                 ` Christopher Faylor
2003-01-29  6:52                               ` David S. Miller
2003-01-28 23:56                         ` kuznet
2003-01-29  0:08                           ` David S. Miller
2003-01-29  3:14                             ` kuznet
2003-01-29  7:32                               ` David S. Miller
2003-01-29 14:12                             ` David C Niemi
2003-01-29 14:24                               ` kuznet
2003-01-29 15:11                                 ` dada1
2003-02-02 15:40                               ` Bill Davidsen
2003-01-27 21:27 ` SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030128.123413.51821993.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=andersg@0x63.nu \
    --cc=benoit-lists@fb12.de \
    --cc=cgf@redhat.com \
    --cc=dada1@cosmosbay.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkernel2003@tuxers.net \
    --cc=tobi@tobi.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox