public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: andersg@0x63.nu, lkernel2003@tuxers.net,
	linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, tobi@tobi.nu
Subject: Re: [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX
Date: Mon, 27 Jan 2003 22:39:03 -0500	[thread overview]
Message-ID: <20030128033903.GA882@redhat.com> (raw)
In-Reply-To: <20030127.143625.84825692.davem@redhat.com>

On Mon, Jan 27, 2003 at 02:36:25PM -0800, David S. Miller wrote:
>Hey guys, can you all see if this patch makes the problem go away in
>2.5.x?  It is merely a guess, but it is worth enough to experiment.
>
>Alexey, this piece of code was buggy first time it was coded, and it
>may still have some holes. :-)))
>
>--- net/ipv4/tcp_output.c.~1~	Mon Jan 27 14:45:49 2003
>+++ net/ipv4/tcp_output.c	Mon Jan 27 14:46:33 2003
>@@ -889,7 +889,7 @@
> 	if (atomic_read(&sk->wmem_alloc) > min(sk->wmem_queued+(sk->wmem_queued>>2),sk->sndbuf))
> 		return -EAGAIN;
> 
>-	if (before(TCP_SKB_CB(skb)->seq, tp->snd_una)) {
>+	if (0 && before(TCP_SKB_CB(skb)->seq, tp->snd_una)) {
> 		if (before(TCP_SKB_CB(skb)->end_seq, tp->snd_una))
> 			BUG();

Sorry, but this doesn't do it for me.  I still get a hang.

cgf

  parent reply	other threads:[~2003-01-28  3:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-24 18:43 SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX David C Niemi
2003-01-24 20:29 ` David S. Miller
2003-01-24 20:46 ` lost
2003-01-24 21:15   ` Christopher Faylor
2003-01-25  2:00     ` SSH Hangs in 2.5.59 and 2.5.55 (TCP_NODELAY?) Christopher Faylor
2003-01-27 14:27 ` SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX David C Niemi
2003-01-27 18:06   ` David S. Miller
2003-01-27 18:11   ` David S. Miller
2003-01-27 18:28     ` Anders Gustafsson
2003-01-27 22:36       ` [TEST FIX] " David S. Miller
2003-01-28  2:25         ` lost
2003-01-28  2:57         ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, kuznet
2003-01-28  3:22           ` Christopher Faylor
2003-01-28  3:39         ` Christopher Faylor [this message]
2003-01-28  3:55           ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX kuznet
2003-01-28  7:08             ` dada1
2003-01-28 12:36               ` Sebastian Benoit
2003-01-28 14:09                 ` kuznet
2003-01-28 18:35                   ` David S. Miller
2003-01-28 19:16                     ` Sebastian Benoit
2003-01-28 20:34                       ` David S. Miller
2003-01-28 21:59                         ` Christopher Faylor
2003-01-28 22:12                         ` Sebastian Benoit
2003-01-28 23:21                           ` David S. Miller
2003-01-29  0:02                             ` [TEST FIX] Re: SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, kuznet
2003-01-29  0:09                             ` kuznet
2003-01-29  0:46                               ` Sebastian Benoit
2003-01-29  4:12                                 ` Christopher Faylor
2003-01-29  6:52                               ` David S. Miller
2003-01-28 23:56                         ` kuznet
2003-01-29  0:08                           ` David S. Miller
2003-01-29  3:14                             ` kuznet
2003-01-29  7:32                               ` David S. Miller
2003-01-29 14:12                             ` David C Niemi
2003-01-29 14:24                               ` kuznet
2003-01-29 15:11                                 ` dada1
2003-02-02 15:40                               ` Bill Davidsen
2003-01-27 21:27 ` SSH Hangs in 2.5.59 and 2.5.55 but not 2.4.x, through Cisco PIX Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030128033903.GA882@redhat.com \
    --to=cgf@redhat.com \
    --cc=andersg@0x63.nu \
    --cc=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkernel2003@tuxers.net \
    --cc=tobi@tobi.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox