public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [RFC] [PATCH] new modversions implementation
Date: Tue, 28 Jan 2003 18:06:17 +1100	[thread overview]
Message-ID: <20030128091625.4790C2C2AC@lists.samba.org> (raw)
In-Reply-To: Your message of "Sat, 25 Jan 2003 22:56:37 BST." <20030125215637.GA3571@mars.ravnborg.org>

In message <20030125215637.GA3571@mars.ravnborg.org> you write:
> On Sat, Jan 25, 2003 at 12:44:39PM -0600, Kai Germaschewski wrote:
> 
> Just some small nit-picking..
> 
> 	Sam
> 
> diff -Nru a/kernel/module.c b/kernel/module.c
> --- a/kernel/module.c   Sat Jan 25 12:25:07 2003
> +++ b/kernel/module.c   Sat Jan 25 12:25:07 2003
> 
> +       kernel_gpl_symbols.num_syms = (__stop___ksymtab_gpl
> +                                      - __start___ksymtab_gpl);
> 
> The member "num_syms" says something about number of symbols,
> but is contains the syms_size. Misleading name.

I think you've missed the declaration:

extern const struct kernel_symbol __start___ksymtab[];
extern const struct kernel_symbol __stop___ksymtab[];
extern const struct kernel_symbol __start___ksymtab_gpl[];
extern const struct kernel_symbol __stop___ksymtab_gpl[];

Thanks for the feedback!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  parent reply	other threads:[~2003-01-28  9:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-25 18:44 [RFC] [PATCH] new modversions implementation Kai Germaschewski
2003-01-25 21:56 ` Sam Ravnborg
2003-01-25 22:56   ` Sam Ravnborg
2003-01-26  2:31     ` Kai Germaschewski
2003-01-26  2:30   ` Kai Germaschewski
2003-01-28  7:07     ` Rusty Russell
2003-01-28 16:40       ` Kai Germaschewski
2003-01-28  7:06   ` Rusty Russell [this message]
2003-01-28 19:20     ` Sam Ravnborg
2003-01-28 10:38 ` Rusty Russell
2003-01-28 16:31   ` Richard Henderson
2003-01-28 16:35     ` Kai Germaschewski
2003-01-29  0:15     ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2003-02-02  8:37 [RFC][PATCH] " Paul Marinceu
2003-02-02  8:51 ` David Woodhouse
2003-02-03  0:46 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030128091625.4790C2C2AC@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox