public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Bill Davidsen <davidsen@tmr.com>
Cc: Linux-Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] Change sendfile header
Date: Thu, 30 Jan 2003 08:34:11 +0000	[thread overview]
Message-ID: <20030130083411.B22879@infradead.org> (raw)
In-Reply-To: <Pine.LNX.3.96.1030129215509.7114C-100000@gatekeeper.tmr.com>; from davidsen@tmr.com on Wed, Jan 29, 2003 at 10:03:04PM -0500

On Wed, Jan 29, 2003 at 10:03:04PM -0500, Bill Davidsen wrote:
> I suggest that the header holding the prototype for sendfile should not be
> in unistd.h because:
> 
> 1 - sendfile is not in SuS, an is extremely non-standard
> 2 - there is a sendfile in BSD and it's totally different
> 3 - there is no man page for sendfile in Solaris, but there is a
>     definition in one of the libraries which is not Linux compatible
> 4 - just putting the "not portable" warning in the man page to counteract
>     the impression given by the <unistd.h> is not enough, programmers
>     usually only read the man page  to get the args right.
> 
> Since Linux sendfile is totally applicable only to Linux, it would seem
> that a better name for the header file, like linux/sendfile.h, would be
> better. This has the advantage of not breaking executables, and requiring
> use of a header file which makes it much harder to overlook the
> portability issue.

You're rant is totally inappropinquate because:

 1 - this is a glibc issue, applications should not include kernel
     headers
 2 - there is no sendfile declaration in glibc's <unistd.h>
 3 - there _is_ a <sys/sendfile.h> for sendfile(64) in glibc
 4 - solaris _does_ have a linux-compatible sendfile now


  parent reply	other threads:[~2003-01-30  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-30  3:03 [RFC] Change sendfile header Bill Davidsen
2003-01-30  4:46 ` Ulrich Drepper
2003-01-30  8:34 ` Christoph Hellwig [this message]
2003-01-31 18:08   ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030130083411.B22879@infradead.org \
    --to=hch@infradead.org \
    --cc=davidsen@tmr.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox