public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Paul Marinceu <elixxir@ucc.gu.uwa.edu.au>
Cc: linux-kernel@vger.kernel.org,
	Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Subject: Re: [RFC][PATCH] new modversions implementation
Date: Mon, 03 Feb 2003 11:46:18 +1100	[thread overview]
Message-ID: <20030203022709.99BAC2C256@lists.samba.org> (raw)
In-Reply-To: Your message of "Sun, 02 Feb 2003 16:37:52 +0800." <Pine.LNX.4.21.0302021616230.11976-100000@mussel>

In message <Pine.LNX.4.21.0302021616230.11976-100000@mussel> you write:
> +#ifdef CONFIG_MODVERSIONING
> +       if ((mod->symbols.num_syms && !crcindex)
> +           || (mod->gpl_symbols.num_syms && !gplcrcindex)) {

Thanks Paul!  Good catch.

Kai is currently the one beating this patch into shape: he's the
Makefile guru, I just twiddle with modules.  I'm waiting for him and
Andrew Morton to merge with Linus to see what's left to apply.

> Also, whatever happened to modversions.h? A module I have refuses to
> compile without it. I'm not yet such a good hacker to figure out how your
> new modversions implementation works 8) 

You shouldn't need modversions.h any more: you can simply excise it.
This means that such a module will taint a modversioned kernel,
though.

The correct (and future-proof) way to build external modules is to use
the kernel makefiles themselves:

http://hypermail.idiosynkrasia.net/linux-kernel/archived/2002/week23/0162.html

Hope that helps!
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  parent reply	other threads:[~2003-02-03  2:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-02  8:37 [RFC][PATCH] new modversions implementation Paul Marinceu
2003-02-02  8:51 ` David Woodhouse
2003-02-03  0:46 ` Rusty Russell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-01-25 18:44 [RFC] [PATCH] " Kai Germaschewski
2003-01-25 21:56 ` Sam Ravnborg
2003-01-25 22:56   ` Sam Ravnborg
2003-01-26  2:31     ` Kai Germaschewski
2003-01-26  2:30   ` Kai Germaschewski
2003-01-28  7:07     ` Rusty Russell
2003-01-28 16:40       ` Kai Germaschewski
2003-01-28  7:06   ` Rusty Russell
2003-01-28 19:20     ` Sam Ravnborg
2003-01-28 10:38 ` Rusty Russell
2003-01-28 16:31   ` Richard Henderson
2003-01-28 16:35     ` Kai Germaschewski
2003-01-29  0:15     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030203022709.99BAC2C256@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=elixxir@ucc.gu.uwa.edu.au \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox