Re: Switch APIC to driver model (and make S3 sleep with APIC on)

[Pavel Machek <pavel@suse.cz>]

Hi!

> > This one should be okay. [oprofile not tested because I don't know how
> > to use it...
> 
> It's not hard you know[1].

should apt-get install oprofile then opcontrol --setup
--vmlinux=/boot/vmlinux --ctr0-count=20000
--ctr0-event=CPU_CLK_UNHALTED && opcontrol --start

do the trick? If that works does it mean oprofile is okay?

> > -struct pm_dev * set_nmi_pm_callback(pm_callback callback)
> > +static int nmi_resume(struct device *dev, u32 level)
> >  {
> > -	apic_pm_unregister(nmi_pmdev);
> > -	return apic_pm_register(PM_SYS_DEV, 0, callback);
> > -}
> > +	if (level != RESUME_POWER_ON)
> > +		return 0;
> > +	setup_apic_nmi_watchdog();
> > +	return 0;
> 
> I don't pretend to understand the PM layer at all, but it looks like
> that both nmi.c's and oprofile's resume functions will get called. This
> won't work: if oprofile has control of the perfctr's/nmi stuff, you
> can't let the NMI watchdog's resume() be called, as it may conflict with
> what oprofile is trying to resume.

oprofile() should already have checks to prevent that, and I added one

[        if (nmi_watchdog == NMI_LOCAL_APIC)
]

to nmi.c. I hope that's okay.
								Pavel
-- 
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?