From: Andrew Morton <akpm@digeo.com>
To: Rik van Riel <riel@conectiva.com.br>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
tytso@thunk.org, rddunlap@osdl.org
Subject: Re: [PATCH][RESEND 3] disassociate_ctty SMP fix
Date: Tue, 4 Feb 2003 17:51:09 -0800 [thread overview]
Message-ID: <20030204175109.57bbfc51.akpm@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.50L.0302042306230.32328-100000@imladris.surriel.com>
Rik van Riel <riel@conectiva.com.br> wrote:
>
> ===== drivers/char/tty_io.c 1.55 vs edited =====
> --- 1.55/drivers/char/tty_io.c Tue Jan 14 23:37:20 2003
> +++ edited/drivers/char/tty_io.c Tue Feb 4 23:02:52 2003
> @@ -425,19 +425,21 @@
> */
> void do_tty_hangup(void *data)
> {
> - struct tty_struct *tty = (struct tty_struct *) data;
> + struct tty_struct *tty;
> struct file * cons_filp = NULL;
> struct task_struct *p;
> struct list_head *l;
> struct pid *pid;
> int closecount = 0, n;
>
> - if (!tty)
> - return;
> -
> /* inuse_filps is protected by the single kernel lock */
> lock_kernel();
> -
> + tty = (struct tty_struct *) data;
> + if (!tty) {
> + unlock_kernel();
> + return;
> + }
> +
> check_tty_count(tty, "do_tty_hangup");
> file_list_lock();
> for (l = tty->tty_files.next; l != &tty->tty_files; l = l->next) {
This part is a no-op...
next prev parent reply other threads:[~2003-02-05 1:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-05 0:36 [PATCH][RESEND 3] disassociate_ctty SMP fix Rik van Riel
2003-02-05 1:07 ` Rik van Riel
2003-02-05 1:51 ` Andrew Morton [this message]
2003-02-05 1:58 ` Rik van Riel
2003-02-05 9:51 ` Russell King
2003-02-05 14:51 ` Russell King
2003-02-05 16:49 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030204175109.57bbfc51.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
--cc=tytso@thunk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox