public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chris@wirex.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: greg@kroah.com, akpm@digeo.com, sds@epoch.ncsc.mil,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Remove duplicate LSM hooks in sendfile
Date: Thu, 6 Feb 2003 16:13:59 -0800	[thread overview]
Message-ID: <20030206161359.A2515@figure1.int.wirex.com> (raw)

Hi,

Somehow the patch to restore the LSM hooks in sendfile got submitted by
Andrew twice (csets 1.974.1.7 and 1.947.32.14 in the current 2.5-bk).
This patch removes the duplication.  Thanks to Stephen Rothwell for
noting this.

Thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net


===== fs/read_write.c 1.27 vs edited =====
--- 1.27/fs/read_write.c	Wed Feb  5 20:04:28 2003
+++ edited/fs/read_write.c	Thu Feb  6 16:10:53 2003
@@ -535,10 +535,6 @@
 	if (retval)
 		goto fput_in;
 
-	retval = security_file_permission (in_file, MAY_READ);
-	if (retval)
-		goto fput_in;
-
 	/*
 	 * Get output file, and verify that it is ok..
 	 */
@@ -553,10 +549,6 @@
 		goto fput_out;
 	out_inode = out_file->f_dentry->d_inode;
 	retval = locks_verify_area(FLOCK_VERIFY_WRITE, out_inode, out_file, out_file->f_pos, count);
-	if (retval)
-		goto fput_out;
-
-	retval = security_file_permission (out_file, MAY_WRITE);
 	if (retval)
 		goto fput_out;
 

                 reply	other threads:[~2003-02-07  0:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030206161359.A2515@figure1.int.wirex.com \
    --to=chris@wirex.com \
    --cc=akpm@digeo.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@epoch.ncsc.mil \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox