public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 2.4.21pre: ide_fix_driveid unresolved in usb-storage
@ 2003-02-06 17:52 Olaf Hering
  2003-02-06 18:21 ` Björn Stenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2003-02-06 17:52 UTC (permalink / raw)
  To: bjorn, marcelo; +Cc: linux-kernel

Hi,

drivers/usb/storage/isd200.c calls ide_fix_driveid()
This function is only available when CONFIG_IDE is active.


--- linux-2.4/drivers/usb/Config.in.olh	2003-02-06 18:43:48.000000000 +0100
+++ linux-2.4/drivers/usb/Config.in	2003-02-06 18:44:08.000000000 +0100
@@ -46,7 +46,7 @@ if [ "$CONFIG_USB" = "y" -o  "$CONFIG_US
       dep_mbool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG $CONFIG_USB_STORAGE
       dep_mbool '    Datafab MDCFE-B Compact Flash Reader support' CONFIG_USB_STORAGE_DATAFAB $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM  $CONFIG_USB_STORAGE
-      dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE
+      dep_mbool '    ISD-200 USB/ATA Bridge support' CONFIG_USB_STORAGE_ISD200 $CONFIG_USB_STORAGE $CONFIG_IDE
       dep_mbool '    Microtech CompactFlash/SmartMedia support' CONFIG_USB_STORAGE_DPCM $CONFIG_USB_STORAGE
       dep_mbool '    HP CD-Writer 82xx support' CONFIG_USB_STORAGE_HP8200e $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL
       dep_mbool '    SanDisk SDDR-09 (and other SmartMedia) support' CONFIG_USB_STORAGE_SDDR09 $CONFIG_USB_STORAGE $CONFIG_EXPERIMENTAL

-- 
A: No.
Q: Should I include quotations after my reply?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] 2.4.21pre: ide_fix_driveid unresolved in usb-storage
  2003-02-06 17:52 [PATCH] 2.4.21pre: ide_fix_driveid unresolved in usb-storage Olaf Hering
@ 2003-02-06 18:21 ` Björn Stenberg
  0 siblings, 0 replies; 2+ messages in thread
From: Björn Stenberg @ 2003-02-06 18:21 UTC (permalink / raw)
  To: Olaf Hering; +Cc: marcelo, linux-kernel

Olaf Hering wrote:
> drivers/usb/storage/isd200.c calls ide_fix_driveid()
> This function is only available when CONFIG_IDE is active.

I know. I submitted a patch for this in September 2002:

http://marc.theaimsgroup.com/?l=linux-usb-devel&m=103305998718432&w=2

...which was rejected "until people make up their minds" about how ide_fix_driveid() should be implemented in various architectures:

http://marc.theaimsgroup.com/?l=linux-usb-devel&m=103310439026491&w=2

I've been meaning to remind Matt and Greg about this issue.

-- 
Björn (not subscribed to lkml)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-06 18:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-06 17:52 [PATCH] 2.4.21pre: ide_fix_driveid unresolved in usb-storage Olaf Hering
2003-02-06 18:21 ` Björn Stenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox