* [PATCH] 2.5.59 : drivers/scsi/advansys.c
@ 2003-02-07 17:24 Frank Davis
2003-02-07 17:35 ` Dave Jones
2003-02-10 0:35 ` Rusty Russell
0 siblings, 2 replies; 3+ messages in thread
From: Frank Davis @ 2003-02-07 17:24 UTC (permalink / raw)
To: linux-kernel; +Cc: fdavis, trivial
Hello all,
The following patch addresses buzilla bug # 324, and removes a double
logical issue. Please review for inclusion.
Regards,
Frank
--- linux/drivers/scsi/advansys.c.old 2003-01-16 21:21:49.000000000 -0500
+++ linux/drivers/scsi/advansys.c 2003-02-07 02:09:58.000000000 -0500
@@ -7100,7 +7100,7 @@
* then return the number of underrun bytes.
*/
if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
- qdonep->remain_bytes <= scp->request_bufflen != 0) {
+ qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {
ASC_DBG1(1, "asc_isr_callback: underrun condition %u bytes\n",
(unsigned) qdonep->remain_bytes);
scp->resid = qdonep->remain_bytes;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] 2.5.59 : drivers/scsi/advansys.c
2003-02-07 17:24 [PATCH] 2.5.59 : drivers/scsi/advansys.c Frank Davis
@ 2003-02-07 17:35 ` Dave Jones
2003-02-10 0:35 ` Rusty Russell
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jones @ 2003-02-07 17:35 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, trivial
On Fri, Feb 07, 2003 at 12:24:54PM -0500, Frank Davis wrote:
> if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
> - qdonep->remain_bytes <= scp->request_bufflen != 0) {
> + qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {
you now have two scp->request_bufflen != 0 checks.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] 2.5.59 : drivers/scsi/advansys.c
2003-02-07 17:24 [PATCH] 2.5.59 : drivers/scsi/advansys.c Frank Davis
2003-02-07 17:35 ` Dave Jones
@ 2003-02-10 0:35 ` Rusty Russell
1 sibling, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2003-02-10 0:35 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, AKellner, support
In message <Pine.LNX.4.44.0302071223250.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 324, and removes a double
> logical issue. Please review for inclusion.
>
> Regards,
> Frank
Once again, the author needs to say what they want here.
Andy?
Thanks,
Rusty.
> --- linux/drivers/scsi/advansys.c.old 2003-01-16 21:21:49.000000000 -0500
> +++ linux/drivers/scsi/advansys.c 2003-02-07 02:09:58.000000000 -0500
> @@ -7100,7 +7100,7 @@
> * then return the number of underrun bytes.
> */
> if (scp->request_bufflen != 0 && qdonep->remain_bytes != 0 &&
> - qdonep->remain_bytes <= scp->request_bufflen != 0) {
> + qdonep->remain_bytes <= scp->request_bufflen && scp->request_bufflen!= 0) {
> ASC_DBG1(1, "asc_isr_callback: underrun condition %u bytes\n",
> (unsigned) qdonep->remain_bytes);
> scp->resid = qdonep->remain_bytes;
>
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-02-10 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-07 17:24 [PATCH] 2.5.59 : drivers/scsi/advansys.c Frank Davis
2003-02-07 17:35 ` Dave Jones
2003-02-10 0:35 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox