[2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[Roger Luethi]

Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
(using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
check with older 2.5.x indicates this problem has been around for a while.

I can provide additional information incl. call trace if anyone's
interested.

Roger

Re: [2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[Pavel Machek]

> Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
> (using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
> check with older 2.5.x indicates this problem has been around for a
> while.


It works for me in 2.5.59. I'm now downloading 2.5.60.

Replacing 

BUG_ON (HWGROUP(drive)->handler);

with

while(HWGROUP(drive)->handler);


might do the trick, but also might corrupt the data badly.

> I can provide additional information incl. call trace if anyone's
> interested.
> 
> Roger

-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.

Re: [2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[Ducrot Bruno]

On Tue, Feb 11, 2003 at 02:21:32PM +0100, Pavel Machek wrote:
> 
> 
> > Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
> > (using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
> > check with older 2.5.x indicates this problem has been around for a
> > while.
> 
> 
> It works for me in 2.5.59. I'm now downloading 2.5.60.
> 
> Replacing 
> 
> BUG_ON (HWGROUP(drive)->handler);
> 
> with
> 
> while(HWGROUP(drive)->handler);
> 
> 
> might do the trick, but also might corrupt the data badly.

IMHO s/might/will/g

-- 
Ducrot Bruno
http://www.poupinou.org        Page profaissionelle
http://toto.tu-me-saoules.com  Haume page

Re: [2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[Roger Luethi]

On Tue, 11 Feb 2003 14:21:32 +0100, Pavel Machek wrote:
> > Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
> > (using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
> > check with older 2.5.x indicates this problem has been around for a
> > while.
> 
> It works for me in 2.5.59. I'm now downloading 2.5.60.

I just saw it happen on 2.5.59 as well. FWIW the machine has 1 GB of RAM,
but HIGHMEM is off for this particular kernel. I won't post jpeg to lkml,
but screen shots are available upon request.

Roger

Re: [2.5.60] swsuspend -> BUG at drivers/ide/ide-disk.c:1557

[Pavel Machek]

Hi!

> > > Is software suspend in Vanilla 2.5.60 supposed to work? A modified shutdown
> > > (using the reboot(2) magic) triggers the BUG_ON in idedisk_suspend. A quick
> > > check with older 2.5.x indicates this problem has been around for a
> > > while.
> > 
> > 
> > It works for me in 2.5.59. I'm now downloading 2.5.60.
> > 
> > Replacing 
> > 
> > BUG_ON (HWGROUP(drive)->handler);
> > 
> > with
> > 
> > while(HWGROUP(drive)->handler);
> > 
> > 
> > might do the trick, but also might corrupt the data badly.
> 
> IMHO s/might/will/g

It should be okay if he forces fsck after the experiments. But yes, it
is pretty risky.
								Pavel
-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.