Re: [patch] input: sunkbd.c - fix reading beyond end of keycode array [14/14]

Vojtech Pavlik
2003-02-13T00:57:03Z

On Wed, Feb 12, 2003 at 08:38:26AM -0800, Randy.Dunlap wrote:
> On Wed, 12 Feb 2003 12:07:57 +0100
> Vojtech Pavlik <vojtech@suse.cz> wrote:
>
> | diff -Nru a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
> | --- a/drivers/input/keyboard/sunkbd.c Wed Feb 12 11:56:22 2003
> | +++ b/drivers/input/keyboard/sunkbd.c Wed Feb 12 11:56:22 2003
> | @@ -268,7 +268,7 @@
> | sprintf(sunkbd->name, "Sun Type %d keyboard", sunkbd->type);
> |
> | memcpy(sunkbd->keycode, sunkbd_keycode, sizeof(sunkbd->keycode));
> | - for (i = 0; i < 255; i++)
> | + for (i = 0; i < 127; i++)
> | set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
> | clear_bit(0, sunkbd->dev.keybit);
> |
>
>
> If sunkbd has a valid keycode 127, that new loop test won't handle it,
> so it should/could be:
> | + for (i = 0; i < 128; i++)

You're right. It doesn't, though.

--
Vojtech Pavlik
SuSE Labs