From: "Theodore Ts'o" <tytso@mit.edu>
To: Andries.Brouwer@cwi.nl
Cc: linux-kernel@vger.kernel.org
Subject: Re: struct tty_driver
Date: Wed, 12 Feb 2003 13:52:52 -0500 [thread overview]
Message-ID: <20030212185252.GA16353@think.thunk.org> (raw)
In-Reply-To: <UTC200302111444.h1BEi7106413.aeb@smtp.cwi.nl>
On Tue, Feb 11, 2003 at 03:44:07PM +0100, Andries.Brouwer@cwi.nl wrote:
> Ted, I wondered:
>
> Looking at 2.5.60 I see
>
> struct tty_struct {
> int magic;
> struct tty_driver driver;
> ...
>
> and it looks like this struct tty_driver is never modified.
> Since it is rather large, why not replace it by
> struct tty_driver *driver;
> ?
>
> As it is now, the initialization in init_dev() does
> tty->driver = *driver;
> just duplicating constant data.
>
> Is this a historical relict, or does this duplication have a function?
Nope. The tty->ldisc should also be made into a pointer as well.
It's a historic relict; it's been a very, very long time since there's
been any variable data in the driver or ldisc structures.
- Ted
prev parent reply other threads:[~2003-02-12 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-11 14:44 struct tty_driver Andries.Brouwer
2003-02-12 18:52 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030212185252.GA16353@think.thunk.org \
--to=tytso@mit.edu \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox