From: Andreas Arens <ari@goron.de>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: [PATCH] AMD IDE oops in current 2.4-ac
Date: Wed, 12 Feb 2003 21:37:10 +0100 [thread overview]
Message-ID: <200302122137.10500.ari@goron.de> (raw)
In-Reply-To: <20030212194912.GA24138@codemonkey.org.uk>
On Wednesday 12 February 2003 20:49, Dave Jones wrote:
> > Current 2.4.21-pre4-ac kernels oops in amd74xx.c with
> > certain chipsets due to a table order problem. The
> > problem is correctly detected by a BUG() in the pci probe
> > routine, which should trigger for all non-nforce chipsets.
>
> If moving entries in the table caused a bug, adding new entries
> could do the same too perhaps ? This sounds quite fragile
> based on your description & diff.
>
amd74xx_probe() compares the pci device ids of both the
probe table and the settings table, so should be save from
misprogramming.
To protect against using random memory after the end
of the table, a bug check on the table size could help:
if (dev->device != d->device) BUG();
+ if (sizeof(amd_ide_chips) >= id->driver_data) BUG();
if (dev->device != amd_config->id) BUG();
Even with this it still looks error prone, especially since
the probe table and the config table are several lines
spread across the file.
Regards
Andy
next prev parent reply other threads:[~2003-02-12 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 19:48 [PATCH] AMD IDE oops in current 2.4-ac Andreas Arens
2003-02-12 19:49 ` Dave Jones
2003-02-12 20:37 ` Andreas Arens [this message]
2003-02-12 22:55 ` Ruslan U. Zakirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302122137.10500.ari@goron.de \
--to=ari@goron.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox