* Strange TCP with 2.5.60
@ 2003-02-12 11:52 Kostadin Karaivanov
2003-02-12 18:24 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Kostadin Karaivanov @ 2003-02-12 11:52 UTC (permalink / raw)
To: linux-kernel
Trying to use traceroute i get folowing error:
root@larry:~# uname -a
Linux larry 2.5.60 #20 Tue Feb 11 17:38:42 EET 2003 i686 unknown
root@larry:~# traceroute www.kernel.org
traceroute: findsaddr: Can't find interface
Networking works....... but command route can't give me the status of
default route:
root@larry:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use
Iface
192.168.0.0 0.0.0.0 255.255.240.0 U 0 0 0 eth0
127.0.0.0 0.0.0.0 255.0.0.0 U 0 0 0 lo
root@larry:~# ip route list
192.168.0.0/20 dev eth0 proto kernel scope link src 192.168.1.12
127.0.0.0/8 dev lo scope link
default via 192.168.1.1 dev eth0 metric 1
root@larry:~#
The version of traceroute is 1.4a12
The version of route is net-tools 1.60 / route 1.98 (2001-04-15)
iptables doesn't work as expected too.....
root@larry:~# iptables -A INPUT -i lo -j ACCEPT
root@larry:~# iptables -L -n
Chain INPUT (policy ACCEPT)
target prot opt source destination
ACCEPT all -- 0.0.0.0/0 0.0.0.0/0
Chain FORWARD (policy ACCEPT)
target prot opt source destination
Chain OUTPUT (policy ACCEPT)
target prot opt source destination
everything works fine with 2.5.59 and 2.4.20
I can provide any additional information if needed
Kostadin Karaivanov
Senior System Administrator @ Ministry Of Finance
tel: +359 2 98592062
larry@minfin.bg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Strange TCP with 2.5.60
2003-02-12 11:52 Strange TCP with 2.5.60 Kostadin Karaivanov
@ 2003-02-12 18:24 ` Andrew Morton
2003-02-13 23:27 ` Bill Davidsen
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2003-02-12 18:24 UTC (permalink / raw)
To: larry; +Cc: linux-kernel
"Kostadin Karaivanov" <larry@minfin.bg> wrote:
>
> Trying to use traceroute i get folowing error:
> ...
>
> Networking works....... but command route can't give me the status of
> default route:
> ...
> iptables doesn't work as expected too.....
> ...
> everything works fine with 2.5.59 and 2.4.20
Could you pelase retest with this patch, and tell us how many of these
problems go away?
diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
--- 25/net/ipv4/fib_hash.c~a 2003-02-12 10:23:55.000000000 -0800
+++ 25-akpm/net/ipv4/fib_hash.c 2003-02-12 10:24:00.000000000 -0800
@@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
if (!iter->zone)
goto out;
- if (iter->zone->fz_next)
+ if (iter->zone->fz_next);
break;
}
_
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Strange TCP with 2.5.60
2003-02-12 18:24 ` Andrew Morton
@ 2003-02-13 23:27 ` Bill Davidsen
2003-02-13 23:37 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Bill Davidsen @ 2003-02-13 23:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: larry, linux-kernel
On Wed, 12 Feb 2003, Andrew Morton wrote:
> Could you pelase retest with this patch, and tell us how many of these
> problems go away?
>
> diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
> --- 25/net/ipv4/fib_hash.c~a 2003-02-12 10:23:55.000000000 -0800
> +++ 25-akpm/net/ipv4/fib_hash.c 2003-02-12 10:24:00.000000000 -0800
> @@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
>
> if (!iter->zone)
> goto out;
> - if (iter->zone->fz_next)
> + if (iter->zone->fz_next);
> break;
> }
>
>
> _
is that patch reversed, I hope? The if doesn't do a great deal.
--
bill davidsen <davidsen@tmr.com>
CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Strange TCP with 2.5.60
2003-02-13 23:27 ` Bill Davidsen
@ 2003-02-13 23:37 ` Andrew Morton
2003-02-14 1:18 ` Martin J. Bligh
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2003-02-13 23:37 UTC (permalink / raw)
To: Bill Davidsen; +Cc: larry, linux-kernel
Bill Davidsen <davidsen@tmr.com> wrote:
>
> On Wed, 12 Feb 2003, Andrew Morton wrote:
>
> > Could you pelase retest with this patch, and tell us how many of these
> > problems go away?
> >
> > diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
> > --- 25/net/ipv4/fib_hash.c~a 2003-02-12 10:23:55.000000000 -0800
> > +++ 25-akpm/net/ipv4/fib_hash.c 2003-02-12 10:24:00.000000000 -0800
> > @@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
> >
> > if (!iter->zone)
> > goto out;
> > - if (iter->zone->fz_next)
> > + if (iter->zone->fz_next);
> > break;
> > }
> >
> >
> > _
>
> is that patch reversed, I hope? The if doesn't do a great deal.
It is deliberate. It directly reverts a bugfix which was recently merged.
Apparently the problem is that this combined with recent seq_file conversions
has resulted in changed format of some /proc/net/foo files, which is
confusing some network admin apps.
It is being worked on.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Strange TCP with 2.5.60
2003-02-13 23:37 ` Andrew Morton
@ 2003-02-14 1:18 ` Martin J. Bligh
2003-02-14 14:41 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Martin J. Bligh @ 2003-02-14 1:18 UTC (permalink / raw)
To: Andrew Morton, Bill Davidsen; +Cc: larry, linux-kernel
>> > Could you pelase retest with this patch, and tell us how many of these
>> > problems go away?
>> >
>> > diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
>> > --- 25/net/ipv4/fib_hash.c~a 2003-02-12 10:23:55.000000000 -0800
>> > +++ 25-akpm/net/ipv4/fib_hash.c 2003-02-12 10:24:00.000000000 -0800
>> > @@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
>> >
>> > if (!iter->zone)
>> > goto out;
>> > - if (iter->zone->fz_next)
>> > + if (iter->zone->fz_next);
>> > break;
>> > }
>> >
>> >
>> > _
>>
>> is that patch reversed, I hope? The if doesn't do a great deal.
>
> It is deliberate. It directly reverts a bugfix which was recently merged.
>
> Apparently the problem is that this combined with recent seq_file
> conversions has resulted in changed format of some /proc/net/foo files,
> which is confusing some network admin apps.
>
> It is being worked on.
Can't we do:
- if (iter->zone->fz_next)
+ /* if (iter->zone->fz_next) */
or something similar? Is much less confusing ...
M.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Strange TCP with 2.5.60
2003-02-14 1:18 ` Martin J. Bligh
@ 2003-02-14 14:41 ` Dave Jones
0 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2003-02-14 14:41 UTC (permalink / raw)
To: Martin J. Bligh; +Cc: Andrew Morton, Bill Davidsen, larry, linux-kernel
> > Apparently the problem is that this combined with recent seq_file
> > conversions has resulted in changed format of some /proc/net/foo files,
> > which is confusing some network admin apps.
> >
> > It is being worked on.
>
> Can't we do:
>
> - if (iter->zone->fz_next)
> + /* if (iter->zone->fz_next) */
>
> or something similar? Is much less confusing ...
See "It is being worked on" 8-)
Better to fix it properly..
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-02-14 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-12 11:52 Strange TCP with 2.5.60 Kostadin Karaivanov
2003-02-12 18:24 ` Andrew Morton
2003-02-13 23:27 ` Bill Davidsen
2003-02-13 23:37 ` Andrew Morton
2003-02-14 1:18 ` Martin J. Bligh
2003-02-14 14:41 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox