Re: [PATCH] CFQ scheduler, #2

Jens Axboe
2003-02-15T16:26:15Z

On Sat, Feb 15 2003, Rik van Riel wrote:
> On Sat, 15 Feb 2003, Mike Galbraith wrote:
>
> >I gave this a burn, and under hefty load it seems to provide a bit of
> >anti-thrash benefit.
>
> Judging from your log, it ends up stalling kswapd and
> dramatically increases the number of times that normal
> processes need to go into the pageout code.

With 30 odds processes, it doesn't take a whole lot for one process to
have its share of requests eaten.

> If this provides an anti-thrashing benefit, something's
> wrong with the VM in 2.5 ;)

It's not a vm problem. But it is a problem if kswapd + pdflush can
consume the entire request pool, stalling real user processes.

Mike, please retry the test with more requests available. CFQ does not
rely on request queue length for fairness. Just changes:

(queue_nr_requests > 128)
queue_nr_requests = 128;

to

(queue_nr_requests > 512)
queue_nr_requests = 512;

in ll_rw_blk.c:blk_dev_init() and see how that runs.

--
Jens Axboe