From: Dave Jones <davej@codemonkey.org.uk>
To: Toplica Tanaskovic <toptan@EUnet.yu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.18 KT400 support
Date: Fri, 14 Feb 2003 17:41:25 +0000 [thread overview]
Message-ID: <20030214174125.GA2694@codemonkey.org.uk> (raw)
In-Reply-To: <200302141821.14768.toptan@EUnet.yu>
On Fri, Feb 14, 2003 at 06:25:52PM +0100, Toplica Tanaskovic wrote:
> Here is the patch that adds complete support for Via KT400 chipsets for
> 2.4.18 kernel
Not complete. This will only work if you have an AGP2.0 card.
There is no code here to setup the bridge in AGP3.0 mode, or handling
what happens when it sees a x8 card. Fully working code is present in
2.5.60-bk if you have time to backport it (hint: I don't right now)
> Don't forget to update yours pci.ids, before applying this patch don't forget
> to update your pci.ids to the latest version.
Has no relevance to the patch. pci.ids is only used by pciutils, and
should not affect behaviour of this agp/ide patch.
Also..
> + { PCI_DEVICE_ID_VIA_8377_0,
> + PCI_VENDOR_ID_VIA,
> + VIA_APOLLO_KT400,
> + "Via",
Should be capitalised 'VIA'.
> --- orig/linux/drivers/ide/via82cxxx.c Wed Mar 27 13:57:19 2002
> +++ linux/drivers/ide/via82cxxx.c Tue Feb 11 22:39:28 2003
> @@ -105,8 +105,8 @@
> } via_isa_bridges[] = {
> #ifdef FUTURE_BRIDGES
> { "vt8237", PCI_DEVICE_ID_VIA_8237, 0x00, 0x2f, VIA_UDMA_133 },
> - { "vt8235", PCI_DEVICE_ID_VIA_8235, 0x00, 0x2f, VIA_UDMA_133 },
> #endif
> + { "vt8235", PCI_DEVICE_ID_VIA_8235, 0x00, 0x2f, VIA_UDMA_133 },
Already in 2.4-bk
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2003-02-14 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-14 17:25 [PATCH] 2.4.18 KT400 support Toplica Tanaskovic
2003-02-14 17:41 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-14 20:50 Nicolas Mailhot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214174125.GA2694@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=toptan@EUnet.yu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox