From: Bob Miller <rem@osdl.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Russell King <rmk@arm.linux.org.uk>,
Lars Magne Ingebrigtsen <larsi@gnus.org>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.60 5/9] Update the Archimedes parallel port driver for new module API.
Date: Mon, 17 Feb 2003 09:03:39 -0800 [thread overview]
Message-ID: <20030217170339.GA23052@doc.pdx.osdl.net> (raw)
In-Reply-To: <20030217030304.60DFA2C30D@lists.samba.org>
On Mon, Feb 17, 2003 at 01:54:59PM +1100, Rusty Russell wrote:
> In message <20030215100424.A20365@flint.arm.linux.org.uk> you write:
> > On Fri, Feb 14, 2003 at 04:37:00PM -0800, Bob Miller wrote:
> > > -static void arc_inc_use_count(void)
> > > +static int arc_inc_use_count(void)
> > > {
> > > -#ifdef MODULE
> > > - MOD_INC_USE_COUNT;
> > > -#endif
> > > + return try_module_get(THIS_MODULE);
> > > }
> >
> > Isn't one of the points of the module system that we don't try to run
> > code inside a module without the module being reference counted?
>
> Exactly. You can do it if you *know* you already hold a reference
> count, but as a general rule it's damn suspicious.
>
> This looks wrong,
> Rusty.
Thanks for the feed back. I'll fix this and re-submit.
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
prev parent reply other threads:[~2003-02-17 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-14 23:53 [PATCH 2.5.60 5/9] Update the Archimedes parallel port driver for new module API Bob Miller
[not found] ` <m3el6agzw0.fsf@quimbies.gnus.org>
2003-02-15 0:37 ` Bob Miller
2003-02-15 10:04 ` Russell King
2003-02-17 2:54 ` Rusty Russell
2003-02-17 17:03 ` Bob Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030217170339.GA23052@doc.pdx.osdl.net \
--to=rem@osdl.org \
--cc=larsi@gnus.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox