From: William Lee Irwin III <wli@holomorphy.com>
To: "Kamble, Nitin A" <nitin.a.kamble@intel.com>
Cc: linux-kernel@vger.kernel.org, "Nakajima,
Jun" <jun.nakajima@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Saxena, Sunil" <sunil.saxena@intel.com>
Subject: Re: [PATCH][2.5] IRQ distribution patch for 2.5.58
Date: Mon, 17 Feb 2003 10:16:14 -0800 [thread overview]
Message-ID: <20030217181614.GP29983@holomorphy.com> (raw)
In-Reply-To: <E88224AA79D2744187E7854CA8D9131DA5CE8D@fmsmsx407.fm.intel.com>
On Thu, Jan 16, 2003 at 01:08:55PM -0800, Kamble, Nitin A wrote:
> + spin_lock(&desc->lock);
> + irq_balance_mask[selected_irq] = target_cpu_mask;
> + spin_unlock(&desc->lock);
Wrong.
irq_balance_mask[selected_irq] = cpu_to_logical_apicid(min_loaded);
... except this needs auditing for the assumption that the RTE's are
using logical DESTMOD.
Guess whose box won't boot with your code in?
-- wli
next prev parent reply other threads:[~2003-02-17 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-16 21:08 [PATCH][2.5] IRQ distribution patch for 2.5.58 Kamble, Nitin A
2003-02-17 18:16 ` William Lee Irwin III [this message]
2003-02-17 18:49 ` Martin J. Bligh
2003-02-17 18:59 ` Dave Hansen
2003-02-18 3:52 ` Zwane Mwaikambo
2003-02-18 4:15 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030217181614.GP29983@holomorphy.com \
--to=wli@holomorphy.com \
--cc=asit.k.mallick@intel.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nitin.a.kamble@intel.com \
--cc=sunil.saxena@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox