From: Andrew Morton <akpm@digeo.com>
To: Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all()
Date: Thu, 20 Feb 2003 12:20:17 -0800 [thread overview]
Message-ID: <20030220122017.027c023b.akpm@digeo.com> (raw)
In-Reply-To: <200302202002.h1KK2YZ00018@rumms.uni-mannheim.de>
Thomas Schlichter <schlicht@uni-mannheim.de> wrote:
>
> This patch replaces the flush_map() function in the arch/i386/mm/pageattr.c
> file with flush_tlb_all() calls, as the flush_map() function wants to do
> the same, but just forgot the preempt_disable() and preempt_enable() calls.
>
flush_map() is doing a wbinvd:
> -static void flush_kernel_map(void *dummy)
> -{
> - /* Could use CLFLUSH here if the CPU supports it (Hammer,P4) */
> - if (boot_cpu_data.x86_model >= 4)
> - asm volatile("wbinvd":::"memory");
It appears that by replacing flush_map() with flush_tlb_all(), you are no
longer doing this?
next prev parent reply other threads:[~2003-02-20 20:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-20 20:00 [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c with flush_tlb_all() Thomas Schlichter
2003-02-20 20:20 ` Andrew Morton [this message]
2003-02-20 20:36 ` Dave Jones
2003-02-20 20:30 ` Thomas Schlichter
2003-02-20 20:50 ` Dave Jones
2003-02-21 11:24 ` Thomas Schlichter
2003-02-21 12:19 ` [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c w ith flush_tlb_all() Hugh Dickins
2003-02-21 12:42 ` Thomas Schlichter
2003-02-21 14:20 ` Dave Jones
2003-02-21 14:25 ` Thomas Schlichter
2003-02-21 15:01 ` Dave Jones
2003-02-21 14:52 ` Hugh Dickins
2003-02-21 15:10 ` Dave Jones
2003-02-21 17:36 ` Dave Jones
2003-02-22 3:23 ` [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030220122017.027c023b.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox