Re: asm-i386/numaq.h fixes

Martin J. Bligh
2003-02-17T16:51:34Z

> As can be seen from:
>
> http://www-3.ibm.com/software/data/db2/benchmarks/050300.html
>
> MAX_NUMNODES is 16 on NUMA-Q, not 8.

Not unless we have NUM_CPUS > BITS_PER_LONG it's not. Please don't change that.

> Also, PHYSADDR_TO_NID() needs to parenthesize its argument.

Fair enough.

> -- wli
>
> ===== include/asm-i386/numaq.h 1.5 vs edited =====
> --- 1.5/include/asm-i386/numaq.h Tue Jan 7 03:11:19 2003
> +++ edited/include/asm-i386/numaq.h Sun Feb 16 23:47:34 2003
> @@ -37,8 +37,8 @@
> #define PAGES_PER_ELEMENT (16777216/256)
>
> #define pfn_to_pgdat(pfn) NODE_DATA(pfn_to_nid(pfn))
> -#define PHYSADDR_TO_NID(pa) pfn_to_nid(pa >> PAGE_SHIFT)
> -#define MAX_NUMNODES 8
> +#define PHYSADDR_TO_NID(pa) pfn_to_nid((pa) >> PAGE_SHIFT)
> +#define MAX_NUMNODES 16
> extern int pfn_to_nid(unsigned long);
> extern void get_memcfg_numaq(void);
> #define get_memcfg_numa() get_memcfg_numaq()
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>