Re: xdr nfs highmem deadlock fix [Re: filesystem access slowing system to a crawl]

Andrea Arcangeli
2003-02-21T09:31:51Z

On Thu, Feb 20, 2003 at 06:04:30PM -0500, Jeff Garzik wrote:
> On Thu, Feb 20, 2003 at 11:56:14PM +0100, Trond Myklebust wrote:
> > >>>>> " " == Andrea Arcangeli <andrea@suse.de> writes:
> >
> > > 2.5.62 has the very same deadlock condition in xdr triggered by
> > > nfs too.
> > > Andrew, if you're forward porting it yourself like with the
> > > filebacked vma merging feature just let me know so we make sure
> > > not to duplicate effort.
> >
> > For 2.5.x we should rather fix MSG_MORE so that it actually works
> > instead of messing with hacks to kmap().
> >
> > For 2.4.x, Hirokazu Takahashi had a patch which allowed for a safe
> > kmap of > 1 page in one call. Appended here as an attachment FYI
> > (Marcelo do *not* apply!).
>
>
> One should also consider kmap_atomic... (bcrl suggest)

impossible, either you submit page structures to the IP layer, or you
*must* have persistence, depending on a sock_sendmsg that can't schedule
would be totally broken (or the preemptive thing is a joke). nfs client
O_DIRET zerocopy would be a nice feature but this is 2.4.

the only option would be the atomic and at the same time persistent
kmaps in the process address space that don't work well with threads...
but again this is 2.4 and we miss it even in 2.5 because of the troubles
they generate.

Andrea