From: Andrew Morton <akpm@digeo.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: andrea@suse.de, m.c.p@wolk-project.de, t.baetzler@bringe.com,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br
Subject: Re: xdr nfs highmem deadlock fix [Re: filesystem access slowing system to a crawl]
Date: Fri, 21 Feb 2003 12:52:59 -0800 [thread overview]
Message-ID: <20030221125259.5d22a42f.akpm@digeo.com> (raw)
In-Reply-To: <shs1y22zhm9.fsf@charged.uio.no>
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> >>>>> " " == Andrea Arcangeli <andrea@suse.de> writes:
>
> > 2.5.62 has the very same deadlock condition in xdr triggered by
> > nfs too.
> > Andrew, if you're forward porting it yourself like with the
> > filebacked vma merging feature just let me know so we make sure
> > not to duplicate effort.
>
> For 2.5.x we should rather fix MSG_MORE so that it actually works
> instead of messing with hacks to kmap().
Is the fixing of MSG_MORE likely to actually happen?
> For 2.4.x, Hirokazu Takahashi had a patch which allowed for a safe
> kmap of > 1 page in one call. Appended here as an attachment FYI
> (Marcelo do *not* apply!).
Andrea's patch is quite simple. Although I wonder if this, in
xdr_kmap():
+ } else {
+ iov->iov_base = kmap_nonblock(*ppage);
+ if (!iov->iov_base)
+ goto out;
+ }
should be skipping the map_tail thing?
next prev parent reply other threads:[~2003-02-21 20:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-04 9:29 filesystem access slowing system to a crawl Thomas Bätzler
2003-02-05 9:03 ` Denis Vlasenko
2003-02-05 9:39 ` Andrew Morton
2003-02-19 16:42 ` Marc-Christian Petersen
2003-02-19 17:49 ` Andrea Arcangeli
2003-02-20 15:29 ` Marc-Christian Petersen
2003-02-20 18:35 ` Andrew Morton
2003-02-20 21:32 ` Marc-Christian Petersen
2003-02-20 21:41 ` Andrew Morton
2003-02-20 22:08 ` Andrea Arcangeli
2003-02-20 21:54 ` xdr nfs highmem deadlock fix [Re: filesystem access slowing system to a crawl] Andrea Arcangeli
2003-02-20 22:56 ` Trond Myklebust
2003-02-20 23:04 ` Jeff Garzik
2003-02-20 23:12 ` Trond Myklebust
2003-02-21 9:41 ` Andrea Arcangeli
2003-02-22 0:40 ` David S. Miller
2003-02-23 15:22 ` Andrea Arcangeli
2003-02-21 9:41 ` Andrea Arcangeli
2003-02-21 9:37 ` Andrea Arcangeli
2003-02-21 20:52 ` Andrew Morton [this message]
2003-02-21 21:32 ` Trond Myklebust
2003-02-20 23:15 ` Andreas Dilger
2003-02-21 9:46 ` Andrea Arcangeli
2003-02-21 19:41 ` Andreas Dilger
2003-02-21 19:46 ` Andrea Arcangeli
2003-02-26 23:17 ` filesystem access slowing system to a crawl Marc-Christian Petersen
2003-02-27 8:51 ` Marc-Christian Petersen
2003-02-20 19:30 ` William Stearns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030221125259.5d22a42f.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.c.p@wolk-project.de \
--cc=marcelo@conectiva.com.br \
--cc=t.baetzler@bringe.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox