[PATCH TRIVIAL] forgotten include in char/epca.c

[PATCH TRIVIAL] forgotten include in char/epca.c

[Maciej Soltysiak]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3513 bytes --]

Hi,

this simple patch eliminates gcc warnings in epca.c:

drivers/char/epca.c: In function `pc_close':
drivers/char/epca.c:522: warning: implicit declaration of function
`save_flags'
drivers/char/epca.c:523: warning: implicit declaration of function `cli'
drivers/char/epca.c:527: warning: implicit declaration of function
`restore_flags'
drivers/char/epca.c:506: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `shutdown':
drivers/char/epca.c:620: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_hangup':
drivers/char/epca.c:683: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_write':
drivers/char/epca.c:723: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_write_room':
drivers/char/epca.c:1024: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_chars_in_buffer':
drivers/char/epca.c:1075: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_flush_buffer':
drivers/char/epca.c:1143: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_flush_chars':
drivers/char/epca.c:1191: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `block_til_ready':
drivers/char/epca.c:1217: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_open':
drivers/char/epca.c:1371: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_init':
drivers/char/epca.c:1634: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `epcapoll':
drivers/char/epca.c:2210: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_ioctl':
drivers/char/epca.c:2964: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_set_termios':
drivers/char/epca.c:3365: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_stop':
drivers/char/epca.c:3437: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_start':
drivers/char/epca.c:3485: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_throttle':
drivers/char/epca.c:3530: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `pc_unthrottle':
drivers/char/epca.c:3564: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `digi_send_break':
drivers/char/epca.c:3602: warning: `flags' might be used uninitialized in
this function
drivers/char/epca.c: In function `setup_empty_event':
drivers/char/epca.c:3629: warning: `flags' might be used uninitialized in
this function

Regards,
Maciej Soltysiak

ps. why have my spelling patches not been included ? i have seen other
people's typo patches since bk3-bk4. Please look for my two simple
spelling patches.


--- linux-2.5.60/drivers/char/epca.c~	2003-02-20 14:36:56.000000000 +0100
+++ linux-2.5.60/drivers/char/epca.c	2003-02-21 17:40:01.000000000 +0100
@@ -41,6 +41,7 @@
 #include <linux/slab.h>
 #include <linux/ioport.h>
 #include <asm/uaccess.h>
+#include <linux/interrupt.h>
 #include <asm/io.h>

 #ifdef CONFIG_PCI

[-- Attachment #2: epca.c.diff --]
[-- Type: TEXT/plain, Size: 325 bytes --]

--- linux-2.5.60/drivers/char/epca.c~	2003-02-20 14:36:56.000000000 +0100
+++ linux-2.5.60/drivers/char/epca.c	2003-02-21 17:40:01.000000000 +0100
@@ -41,6 +41,7 @@
 #include <linux/slab.h>
 #include <linux/ioport.h>
 #include <asm/uaccess.h>
+#include <linux/interrupt.h>
 #include <asm/io.h>
 
 #ifdef CONFIG_PCI

Re: [PATCH TRIVIAL] forgotten include in char/epca.c

[Dave Jones]

On Fri, Feb 21, 2003 at 05:56:24PM +0100, Maciej Soltysiak wrote:

 > this simple patch eliminates gcc warnings in epca.c:

This 'fixes' things temporarily for UP, but is completely broken on SMP.
cli/sti and friends are long since dead (2.5.28).

See Documentation/cli-sti-removal.txt

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs