Re: 2.4 iget5_locked port attempt to 2.4

Anton Altaparmakov
2003-03-03T16:17:02Z

On Mon, 3 Mar 2003, Oleg Drokin wrote:
> On Mon, Mar 03, 2003 at 03:57:19PM +0000, Anton Altaparmakov wrote:
> > > > > It's me again, I basically got no reply for this iget5_locked patch
> > > > > I have now. Would there be any objections if I try push it to Marcelo
> > > > > tomorrow? ;)
> > > > I just binned it. Certainly its not the kind of stuff I want to test in -ac,
> > > > too many VFS changes outside reiserfs
> > > Andrew Morton said "iget5_locked() looks simple enough, and as far as I can
> > > tell does not change any existing code - it just adds new stuff.",
> > > also this code (in its 2.5 incarnation) was tested in 2.5 for long time already.
> > > Also it fixes real bug (and while I have another reiserfs-only fix for the bug,
> > > it is fairly inelegant).
> > I agree it should go into 2.4 but I don't think the patches you are
> > submitting should go in. From what I can see they are an older version
> > compared to what actually went into 2.5. (I am basing this on the comments
>
> What I am submitting is just changesets 1.373.172.1..1.373.172.6 from
> 2.5 bk tree. So these patches are what went into 2.5 (plus all the bugs I
> have made during adapting these to 2.4, of course).

That's ok then.

> > to the functions rather than thorough code comparisons but I don't have
> > time to look at it more in depth atm.) Why don't you use the actual 2.5
> > code and make new patches or at least make use of the patches that finally
> > went into 2.5?
>
> Looking at the changelog, it seems much later on there were ifind_fast() and ifind()
> additions to this code, but I was not sure I should take these too.
> I can though, if people think that would be useful.

Up to you. Would be nice to have both. The code with the ifind() and
ilookup() functions has existed for longer I think so if your argument
is that the code has been tested in 2.5 already so can go in 2.4 then
taking that is probably better to take these, too.

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/