From: "David S. Miller" <davem@redhat.com>
To: hch@infradead.org
Cc: ak@suse.de, sim@netnation.com, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org
Subject: Re: Longstanding networking / SMP issue? (duplextest)
Date: Sun, 23 Feb 2003 01:58:19 -0800 (PST) [thread overview]
Message-ID: <20030223.015819.94389615.davem@redhat.com> (raw)
In-Reply-To: <20030223100234.B15347@infradead.org>
From: Christoph Hellwig <hch@infradead.org>
Date: Sun, 23 Feb 2003 10:02:34 +0000
> + icmp_xmit_lock();
Hmm, and I guess the code would be much more readable if you used
the spin_lock call directly. The impliclit icmp_socket doesn't
really help readability either.
Sure it does, it encapsulates the icmp_socket->sk->foo->far->fum
dereferencing into one place instead of 4.
next prev parent reply other threads:[~2003-02-23 10:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030219174757.GA5373@netnation.com.suse.lists.linux.kernel>
2003-02-20 7:52 ` Longstanding networking / SMP issue? (duplextest) Andi Kleen
2003-02-20 7:38 ` David S. Miller
2003-02-20 9:20 ` Simon Kirby
2003-02-20 9:34 ` Andi Kleen
2003-02-20 10:12 ` dada1
2003-02-20 10:54 ` Andi Kleen
2003-02-20 11:03 ` dada1
2003-02-21 4:24 ` David S. Miller
2003-02-21 7:27 ` Andi Kleen
2003-02-21 9:43 ` David S. Miller
2003-02-21 10:22 ` Andi Kleen
2003-02-21 10:11 ` David S. Miller
2003-02-21 10:45 ` Andi Kleen
2003-02-23 9:12 ` David S. Miller
2003-02-23 10:02 ` Christoph Hellwig
2003-02-23 9:55 ` David S. Miller
2003-02-23 10:30 ` Andi Kleen
2003-02-23 10:23 ` David S. Miller
2003-02-23 10:37 ` Christoph Hellwig
2003-02-23 9:58 ` David S. Miller [this message]
2003-02-21 15:15 ` Bill Davidsen
2003-02-19 17:47 Simon Kirby
2003-02-19 21:17 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030223.015819.94389615.davem@redhat.com \
--to=davem@redhat.com \
--cc=ak@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=sim@netnation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox