From: Dominik Brodowski <linux@brodo.de>
To: Pavel Machek <pavel@ucw.cz>, torvalds@transmeta.com
Cc: cpufreq@www.linux.org.uk, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: cpufreq: allow user to specify voltage
Date: Tue, 25 Feb 2003 01:41:26 +0100 [thread overview]
Message-ID: <20030225004126.GA2477@brodo.de> (raw)
In-Reply-To: <20030224225545.GA16991@elf.ucw.cz>
Hi Pavel, Hi Linus,
> Hi!
>
> This allows user to specify voltage manually. This gives me 40 extra
> minutes (1h50m -> 2h30m) on HP omnibook which appears to have broken
> bios tables. Please apply,
>
> Pavel
Please don't apply this patch -- for the following reasons:
- it only uses the deprecated, overloaded cpufreq proc_intf
- selecting the voltage within the policy (minimum and maximum frequency,
mode of operation) is not where it should be done: you may want a
different voltage at min-speed as at max-speed. So the frequency tables,
or -even better- the amd-k7-specific table may be a better choice for
this.
- selecting the voltage manually is something which is only valid for some
very few drivers - so let's only export one sysfs file[*] for these
drivers.
Dominik
[*] sysfs is the _only_ recommended way to access cpufreq these days.
next prev parent reply other threads:[~2003-02-25 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 22:55 cpufreq: allow user to specify voltage Pavel Machek
2003-02-25 0:41 ` Dominik Brodowski [this message]
2003-02-25 18:03 ` Pavel Machek
2003-02-25 18:24 ` Dominik Brodowski
2003-02-25 19:09 ` Pavel Machek
2003-02-25 19:28 ` John Clemens
2003-02-25 19:33 ` Pavel Machek
2003-02-28 21:16 ` [PATCH][RFC] " Dominik Brodowski
2003-03-06 0:29 ` Pavel Machek
2003-03-06 0:36 ` Pavel Machek
2003-03-06 20:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030225004126.GA2477@brodo.de \
--to=linux@brodo.de \
--cc=cpufreq@www.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox