Re: [PATCH/RFC] New module refcounting for net_proto_family

Christoph Hellwig
2003-02-21T08:36:01Z

On Thu, Feb 20, 2003 at 05:17:52PM -0800, Max Krasnyansky wrote:
> Yeah, I think 'try' is definitely be a misnomer in this case.
> How about something like this ?
>
> static inline void __module_get(struct module *mod)
> {
> #ifdef CONFIG_MODULE_DETECT_API_VIOLATION
> if (!module_refcount(mod))
> __unsafe(mod);
> #endif
> local_inc(&mod->ref[get_cpu()].count);
> put_cpu();
> }
>
> We will be able to compile the kernel with CONFIG_MODULE_DETECT_API_VIOLATION
> and easily find all modules that call __module_get() without holding a reference.

Drop the ifdef, add and add an unlikely instead?