From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Rick Lindsley <ricklind@us.ibm.com>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] Make diskstats per-cpu using kmalloc_percpu
Date: Tue, 25 Feb 2003 15:09:08 +0530 [thread overview]
Message-ID: <20030225093908.GD28052@in.ibm.com> (raw)
In-Reply-To: <200302250828.h1P8S5s04503@owlet.beaverton.ibm.com>
On Tue, Feb 25, 2003 at 12:28:05AM -0800, Rick Lindsley wrote:
> This version makes the disk stats on struct gendisk per-cpu.
> I am working on making the per partition stats per-cpu too (struct
> hd_struct).
>
> In general I'm in favor of this. It seems intuitive to me that counters
> of this type should be per-cpu. But the question is, do we actually
> see any gains? At the very least, are we sure we've not introduced any
> degradation? Has any of your testing so far been measuring performance or
> just checking for correctness?
Tests on this patch have been for correctness. However, we had done some
measurements sometime back (actually loong time back) to verify if we actually
saw any gains with similar statistics counters. The results are at
http://lse.sourceforge.net/counters/statctr.html
Since, we already know that per-cpu counters are good from our experiments
earlier, I did not bother doing it for this patch.
prev parent reply other threads:[~2003-02-25 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 7:36 [patch] Make diskstats per-cpu using kmalloc_percpu Ravikiran G Thirumalai
2003-02-25 7:56 ` Andrew Morton
2003-02-25 9:29 ` Ravikiran G Thirumalai
2003-02-25 8:28 ` Rick Lindsley
2003-02-25 9:39 ` Ravikiran G Thirumalai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030225093908.GD28052@in.ibm.com \
--to=kiran@in.ibm.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox