From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: braam@clusterfs.com, linux-kernel@vger.kernel.org,
david+cert@blue-labs.org
Subject: Re: [OOPS] 2.5.62, bootup, do_add_mount
Date: Tue, 25 Feb 2003 15:17:11 +0530 [thread overview]
Message-ID: <20030225094711.GE1109@in.ibm.com> (raw)
In-Reply-To: <20030225000448.6f5e0d22.akpm@digeo.com>
On Tue, Feb 25, 2003 at 12:04:48AM -0800, Andrew Morton wrote:
> Maneesh Soni <maneesh@in.ibm.com> wrote:
> >
> >
> > Hi Peter,
> >
> > presto_get_sb() is returning error resulting in the following NULL
> > pointer reference in do_kern_mount(). The following patch corrects
> > it.
> >
>
> It should be returning some ERR_PTR value. Seems that presto_get_sb() isn't
> very careful in tracking the reason for the failed mount, so
>
> return ERR_PTR(-EINVAL);
>
> should suffice.
Actually previous fix I posted is not correct also. Returning -EINVAL seems
logical.
diff -urN linux-2.5.63-base/fs/intermezzo/super.c linux-2.5.63-presto_get_sb/fs/intermezzo/super.c
--- linux-2.5.63-base/fs/intermezzo/super.c 2003-02-25 00:36:01.000000000 +0530
+++ linux-2.5.63-presto_get_sb/fs/intermezzo/super.c 2003-02-25 15:14:09.000000000 +0530
@@ -318,7 +318,7 @@
CDEBUG(D_MALLOC, "mount error exit: kmem %ld, vmem %ld\n",
presto_kmemory, presto_vmemory);
- return NULL;
+ return ERR_PTR(-EINVAL);
}
Regards,
Maneesh
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
next prev parent reply other threads:[~2003-02-25 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-22 4:47 [OOPS] 2.5.62, bootup, do_add_mount David Ford
2003-02-25 8:03 ` Maneesh Soni
2003-02-25 8:04 ` Andrew Morton
2003-02-25 9:47 ` Maneesh Soni [this message]
2003-02-25 20:06 ` Peter Braam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030225094711.GE1109@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=akpm@digeo.com \
--cc=braam@clusterfs.com \
--cc=david+cert@blue-labs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox