From: William Lee Irwin III <wli@holomorphy.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: cpu-2.5.63-1
Date: Tue, 25 Feb 2003 13:40:43 -0800 [thread overview]
Message-ID: <20030225214043.GG10411@holomorphy.com> (raw)
In-Reply-To: <20030225133207.2352bb9a.rddunlap@osdl.org>
On Tue, Feb 25, 2003 at 01:32:07PM -0800, Randy.Dunlap wrote:
- if (target_cpu_mask & allowed_mask) {
+ if (cpus_empty(tmp)) {
# ? if (!cpus_empty(tmp)) {
Yep, that's a bug.
On Tue, Feb 25, 2003 at 01:32:07PM -0800, Randy.Dunlap wrote:
-#define BITS_TO_LONGS(bits) \
- (((bits)+BITS_PER_LONG-1)/BITS_PER_LONG)
# keep this and use it. (but moved from another file)
+#define DECLARE_BITMAP(name,bits) \
+ unsigned long name[((bits)+BITS_PER_LONG-1)/BITS_PER_LONG]
# unsigned long name[BITS_TO_LONGS(bits)]
+#define CLEAR_BITMAP(name,bits) \
+ memset(name, 0, ((bits)+BITS_PER_LONG-1)/8)
# memset(name, 0, BITS_TO_LONGS(bits) * (BITS_PER_LONG / 8))
# This clears all longs in <name>, so that extra code below can disappear.
Header ordering stuff. A wee bit brute-force. All good cleanups.
You originally spotted the bitmap_fill() typo too.
Looks like time for a cpu-2.5.63-2 with your changes.
-- wli
next prev parent reply other threads:[~2003-02-25 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 17:54 cpu-2.5.63-1 William Lee Irwin III
2003-02-25 21:32 ` cpu-2.5.63-1 Randy.Dunlap
2003-02-25 21:40 ` William Lee Irwin III [this message]
2003-02-26 2:20 ` cpu-2.5.63-1 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030225214043.GG10411@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox