Re: [PATCH][2.5] fix preempt-issues with smp_call_function()

Dave Jones
2003-02-26T09:30:10Z

On Tue, Feb 25, 2003 at 07:08:48PM +0100, Thomas Schlichter wrote:

> here is a patch to solve all (I hope I missed none) possible problems that
> could occur on SMP machines running a preemptible kernel when
> smp_call_function() calls a function which should be also executed on the
> current processor.
>
> This patch is based on the one Dave Jones sent to the LKML last friday and
> applies to the linux kernel version 2.5.63.

Just one comment. You moved quite a few of the preempt_disable/enable
pairs outside of the CONFIG_SMP checks. The issue we're working against
here is to try and prevent preemption and ending up on a different CPU.
As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.

Dave