Re: [PATCH][2.5] fix preempt-issues with smp_call_function()

Dave Jones
2003-02-26T10:11:18Z

On Wed, Feb 26, 2003 at 01:54:09AM -0800, Andrew Morton wrote:

> > Just one comment. You moved quite a few of the preempt_disable/enable
> > pairs outside of the CONFIG_SMP checks. The issue we're working against
> > here is to try and prevent preemption and ending up on a different CPU.
> > As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.
> Just in two places.

Ok, slight exaggeration 8-) Looks good to me.

btw, (unrelated) shouldn't smp_call_function be doing magick checks
with cpu_online() ?

Dave