public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] Use hex numbers in fs/block_dev.c
Date: Wed, 26 Feb 2003 17:19:15 +0100	[thread overview]
Message-ID: <200302261719.15884@bilbo.math.uni-mannheim.de> (raw)

We're using hex numbers to identify devices in most places. We should use
them in filesystem messages, errors etc. too, this would be much more
consistent and avoids things like this where two different naming styles
for the same error are used:

     end_request: [...] dev 16:45 (hdd), sector 9175248
     EXT3-fs error (device ide1(22,69)): [...] inode=575269, block=1146906

With this patch the second message would look like this:

     EXT3-fs error (device ide1(16:45)): [...] inode=575269, block=1146906

This code is used in some drivers outside fs/ too, but there only in *print*
or DEBUG's.

Eike

--- linux-2.5.63-eike/fs/block_dev.c.orig	Tue Feb 25 08:15:45 2003
+++ linux-2.5.63-eike/fs/block_dev.c	Wed Feb 26 16:04:28 2003
@@ -794,7 +794,7 @@
 	if (!name)
 		name = "unknown-block";
 
-	sprintf(buffer, "%s(%d,%d)", name, MAJOR(dev), MINOR(dev));
+	sprintf(buffer, "%s(%x:%x)", name, MAJOR(dev), MINOR(dev));
 	return buffer;
 }
 

             reply	other threads:[~2003-02-26 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-26 16:19 Rolf Eike Beer [this message]
2003-02-26 16:37 ` [PATCH] Use hex numbers in fs/block_dev.c Jörn Engel
2003-02-26 17:01   ` Rolf Eike Beer
2003-02-27  0:12     ` jw schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302261719.15884@bilbo.math.uni-mannheim.de \
    --to=eike-kernel@sf-tec.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox