From: Ben Collins <bcollins@debian.org>
To: "David S. Miller" <davem@redhat.com>
Cc: pavel@suse.cz, linux-kernel@vger.kernel.org,
schwidefsky@de.ibm.com, ak@suse.de, arnd@bergmann-dalldorf.de
Subject: Re: ioctl32 consolidation -- call for testing
Date: Thu, 27 Feb 2003 15:50:44 -0500 [thread overview]
Message-ID: <20030227205044.GQ21100@phunnypharm.org> (raw)
In-Reply-To: <20030227.122126.30208201.davem@redhat.com>
On Thu, Feb 27, 2003 at 12:21:26PM -0800, David S. Miller wrote:
> From: Ben Collins <bcollins@debian.org>
> Date: Thu, 27 Feb 2003 15:34:40 -0500
>
> On Thu, Feb 27, 2003 at 12:13:02PM -0800, David S. Miller wrote:
> > From: Ben Collins <bcollins@debian.org>
> > Date: Thu, 27 Feb 2003 15:27:39 -0500
> >
> > Here it is. Sparc64's macros for ioctl32's assumed that cmd was u_int
> > instead of u_long. This look ok to you, Dave?
> >
> > We would love to see that patch :-)
>
> It was real small...so small that it slipped through mutt's open() call
> and never got attached :)
>
> Well, you just doubled the size of the table on sparc64.
> I don't know if I like that.
Not much of a way around it. Might seem like a big hit now (I think it's
like 4k extra), but once these ioctl's start moving into their own
driver, and out of arch/*/ioctl32.c, you'll start to get savings anyway.
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo - http://www.deqo.com/
next prev parent reply other threads:[~2003-02-27 20:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-26 22:26 ioctl32 consolidation -- call for testing Pavel Machek
2003-02-27 19:44 ` Ben Collins
2003-02-27 19:51 ` Ben Collins
2003-02-27 20:27 ` Ben Collins
2003-02-27 20:13 ` David S. Miller
2003-02-27 20:34 ` Ben Collins
2003-02-27 20:21 ` David S. Miller
2003-02-27 20:50 ` Ben Collins [this message]
2003-02-27 20:37 ` David S. Miller
2003-02-27 21:12 ` Ben Collins
2003-02-28 13:23 ` Pavel Machek
2003-02-28 15:49 ` Ben Collins
2003-03-01 0:52 ` David S. Miller
2003-02-28 13:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030227205044.GQ21100@phunnypharm.org \
--to=bcollins@debian.org \
--cc=ak@suse.de \
--cc=arnd@bergmann-dalldorf.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox