public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Wolfgang Muees <wolfgang@iksw-muees.de>
Cc: lkml <linux-kernel@vger.kernel.org>, greg@kroah.com
Subject: [patch] 2.4.21-pre5: fix Auerswald compile
Date: Fri, 28 Feb 2003 00:26:12 +0100	[thread overview]
Message-ID: <20030227232612.GV7685@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.53L.0302270314050.1433@freak.distro.conectiva>

On Thu, Feb 27, 2003 at 03:14:44AM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.21-pre4 to v2.4.21-pre5
> ============================================
>...
> Wolfgang Muees <wolfgang@iksw-muees.de>:
>   o USB: updated Auerswald driver

I got the following error at the final linking:

<--  snip  -->

...
        --end-group \
        -o vmlinux
...
drivers/usb/usbdrv.o(.text+0x65061): In function `auerchar_open':
: undefined reference to `auerdev_table_mutex'
drivers/usb/usbdrv.o(.text+0x6506a): In function `auerchar_open':
: undefined reference to `auerdev_table_mutex'
drivers/usb/usbdrv.o(.text+0x65087): In function `auerchar_open':
: undefined reference to `auerdev_table'
drivers/usb/usbdrv.o(.text+0x65094): In function `auerchar_open':
: undefined reference to `auerdev_table_mutex'
drivers/usb/usbdrv.o(.text+0x650c1): In function `auerchar_open':
: undefined reference to `auerdev_table_mutex'
drivers/usb/usbdrv.o(.text+0x650da): In function `auerchar_open':
: undefined reference to `auerdev_table_mutex'
make: *** [vmlinux] Error 1

<--  snip  -->

auerdev_table and auerdev_table_mutex are static in auermain.c but used
from auerchar.c. The following patch makes them non-static:

--- linux-2.4.21-pre5-full/drivers/usb/auermain.c.old	2003-02-28 00:15:45.000000000 +0100
+++ linux-2.4.21-pre5-full/drivers/usb/auermain.c	2003-02-28 00:20:49.000000000 +0100
@@ -66,10 +66,10 @@
 extern devfs_handle_t usb_devfs_handle;
 
 /* array of pointers to our devices that are currently connected */
-static struct auerswald *auerdev_table[AUER_MAX_DEVICES];
+struct auerswald *auerdev_table[AUER_MAX_DEVICES];
 
 /* lock to protect the auerdev_table structure */
-static struct semaphore auerdev_table_mutex;
+struct semaphore auerdev_table_mutex;
 
 /*-------------------------------------------------------------------*/
 /* Forwards */


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-02-27 23:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-27  6:14 Linux 2.4.21-pre5 Marcelo Tosatti
2003-02-27  8:24 ` Christoph Hellwig
2003-02-27  8:32 ` Adrian Bunk
2003-02-27 12:40   ` Ben Collins
2003-02-27 19:22     ` ajoshi
2003-02-27 19:35       ` Ben Collins
2003-03-11 23:39         ` Marcelo Tosatti
2003-02-27  8:53 ` Christoph Hellwig
2003-02-27  9:39 ` Ben Lau
2003-02-27 10:19   ` Simon Oosthoek
2003-02-27 10:48     ` Benjamin Herrenschmidt
2003-02-27 11:43       ` Simon Oosthoek
2003-02-28  5:46       ` Ben Lau
2003-02-27 23:26 ` Adrian Bunk [this message]
2003-02-28  7:47   ` [patch] 2.4.21-pre5: fix Auerswald compile Wolfgang Mües
2003-03-05 22:02   ` Greg KH
2003-03-07  2:47 ` Linux 2.4.21-pre5 J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030227232612.GV7685@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=wolfgang@iksw-muees.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox