From: Maneesh Soni <maneesh@in.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Zilvinas Valinskas <zilvinas@gemtek.lt>
Subject: Re: kernel Ooops (2.5.63 bk latest)
Date: Fri, 28 Feb 2003 12:39:05 +0530 [thread overview]
Message-ID: <20030228070905.GA11135@in.ibm.com> (raw)
In-Reply-To: <20030226113718.GA3568@gemtek.lt>
Hi Linus,
The BUG was caught in d_validate() --> dget(). I think the
dentry to be validated can be already on LRU list with d_count
as zero. So, dget_locked should be used in place of dget().
dcache_rcu mistakingly used dget. This patch corrects it.
Please apply the following patch.
diff -urN linux-2.5.63-bk3/fs/dcache.c linux-2.5.63-bk3-d_validate/fs/dcache.c
--- linux-2.5.63-bk3/fs/dcache.c 2003-02-28 12:06:09.000000000 +0530
+++ linux-2.5.63-bk3-d_validate/fs/dcache.c 2003-02-28 12:16:30.000000000 +0530
@@ -1056,7 +1056,7 @@
* as it is parsed under dcache_lock
*/
if (dentry == list_entry(lhp, struct dentry, d_hash)) {
- dget(dentry);
+ __dget_locked(dentry);
spin_unlock(&dcache_lock);
return 1;
}
Regards,
Maneesh
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
next prev parent reply other threads:[~2003-02-28 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-26 11:37 kernel Ooops (2.5.63 bk latest) Zilvinas Valinskas
2003-02-28 7:09 ` Maneesh Soni [this message]
2003-02-28 7:34 ` Andrew Morton
2003-02-28 9:15 ` Maneesh Soni
2003-02-28 9:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030228070905.GA11135@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zilvinas@gemtek.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox