Re: Rising io_load results Re: 2.5.63-mm1

Dave McCracken
2003-02-28T15:46:37Z

--On Friday, February 28, 2003 12:48:06 +0000 Hugh Dickins
<hugh@veritas.com> wrote:

> On Thu, 27 Feb 2003, Andrew Morton wrote:
>>
>> No, it is still wrong. Mapped cannot exceed MemTotal.
>
> It needs this in addition to Dave's patch from yesterday:
>
> --- 2.5.63-objfix-1/mm/rmap.c Thu Feb 27 23:37:28 2003
> +++ 2.5.63-objfix-2/mm/rmap.c Fri Feb 28 12:33:58 2003
> @@ -349,7 +349,8 @@
> BUG();
> if (atomic_read(&page->pte.mapcount) == 0)
> BUG();
> - atomic_dec(&page->pte.mapcount);
> + if (atomic_dec_and_test(&page->pte.mapcount))
> + dec_page_state(nr_mapped);
> return;
> }

D'oh. I should have seen that one. Thanks.

Dave McCracken

======================================================================
Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059
dmccr@us.ibm.com T/L 678-3059