From: Andi Kleen <ak@suse.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, lse-tech@projects.sourceforge.net
Subject: Re: [PATCH] New dcache / inode hash tuning patch
Date: Fri, 28 Feb 2003 19:59:10 +0100 [thread overview]
Message-ID: <20030228185910.GA5694@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0302281039570.3177-100000@home.transmeta.com>
On Fri, Feb 28, 2003 at 10:47:38AM -0800, Linus Torvalds wrote:
> Right now the dcache hash is often something like 17 bits - and we could
> easily make it so that roughly "half" the bits would be based purely on
> the directory. That would still give each directory ~8 bits worth of
> "local hashing", which is fairly reasonable.
Ok I will see if that helps.
>
> > I believe my patch with a bit more tweaking (my current 64K hash table
> > seems to be too small) is suitable even for an soon to be stable
> > kernel.
>
> Quite frankly, right now the only report I've seen about your patch is
> that it made things slightly _slower_.
Actually that's not quite true. The report had a completely different
profile (lots of other functions had different percentages), so it likely
wasn't a comparable workload. I also don't think the NUMAQs are a good test
platform for this because they have 2MB of fast cache per CPU, while
the typical linux multiprocessor machine has much less. Yes you can
fit an 1MB hash table into a 2 MB cache....
I'll generate some new numbers here locally over the weekend on P4,
but I only have a dual to test on and see how it performs.
-Andi
next prev parent reply other threads:[~2003-02-28 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030226164904.GA21342@wotan.suse.de.suse.lists.linux.kernel>
[not found] ` <b3m5sd$1ad$1@penguin.transmeta.com.suse.lists.linux.kernel>
2003-02-28 8:34 ` [PATCH] New dcache / inode hash tuning patch Andi Kleen
2003-02-28 10:27 ` [Lse-tech] " Paul Menage
2003-02-28 10:40 ` Andi Kleen
2003-02-28 18:47 ` Linus Torvalds
2003-02-28 18:59 ` Andi Kleen [this message]
2003-03-01 0:49 ` Jan Harkes
2003-03-01 1:17 ` Andi Kleen
2003-03-01 4:31 ` Ed Tomlinson
2003-03-01 9:08 ` Andi Kleen
2003-03-01 12:34 ` Ed Tomlinson
2003-03-01 18:34 ` Linus Torvalds
2003-02-26 16:49 Andi Kleen
2003-02-27 23:10 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030228185910.GA5694@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@projects.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox