From: Anton Blanchard <anton@samba.org>
To: Andi Kleen <ak@muc.de>
Cc: sfr@canb.auug.org.au, davem@redhat.com, davidm@hpl.hp.com,
linux-kernel@vger.kernel.org, matthew@wil.cx, ralf@gnu.org,
schwidefsky@de.ibm.com, torvalds@transmeta.com
Subject: Re: [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part
Date: Sat, 1 Mar 2003 20:12:24 +1100 [thread overview]
Message-ID: <20030301091224.GE2606@krispykreme> (raw)
In-Reply-To: <20030228103609.GA29955@averell>
> Now there used to be some code that did:
>
> if (get_user(a, &userstruct->firstmember) ||
> __get_user(b, &userstruct->secondmember))
> return -EFAULT;
>
> Assuming that the access_ok in get_user for sizeof(firstmember) covers
> secondmember too which doesn't do access_ok in __get_user. This only
> works assuming it should handle 64bit pointers when there is a memory
> hole at the end of the user process space, otherwise it could
> access kernel pages directly after TASK_SIZE. x86-64 has a big enough
> hole there, i assume sparc64 and ia64 have too, but i don't know
> about the other 64bit ports.
Yeah there are a bunch of those in the ioctl and syscall translation
code that annoys me. ppc64 is safe too, but its not something we should
rely on.
Anton
next prev parent reply other threads:[~2003-03-01 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-28 9:50 [PATCH][COMPAT] compat_sys_fcntl{,64} 1/9 Generic part sfr
2003-02-28 10:36 ` Andi Kleen
2003-03-01 9:12 ` Anton Blanchard [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-11 12:20 Martin Schwidefsky
2003-03-12 4:44 ` Stephen Rothwell
2003-03-12 5:02 ` Linus Torvalds
2003-03-12 5:22 ` Stephen Rothwell
2003-03-12 5:26 ` Linus Torvalds
2003-03-12 5:57 ` Stephen Rothwell
2003-03-12 11:46 ` David S. Miller
2003-03-11 0:41 Stephen Rothwell
2003-03-10 12:43 Arnd Bergmann
2003-03-04 5:58 Stephen Rothwell
2003-02-28 4:33 Stephen Rothwell
2003-02-28 8:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030301091224.GE2606@krispykreme \
--to=anton@samba.org \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=ralf@gnu.org \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox