From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] die kdevname(), die!
Date: Sat, 1 Mar 2003 19:20:38 +0100 [thread overview]
Message-ID: <20030301192038.A2248@lst.de> (raw)
In-Reply-To: <20030301191441.A2185@lst.de>; from hch@lst.de on Sat, Mar 01, 2003 at 07:14:41PM +0100
On Sat, Mar 01, 2003 at 07:14:41PM +0100, Christoph Hellwig wrote:
> On Sat, Mar 01, 2003 at 10:10:23AM -0800, Linus Torvalds wrote:
> >
> > I really think that replacing "kdevname()" with "__bdevname()" is a step
> > in the wrong direction (or at least sideways).
>
> kdevname() is the really wrong interface because it doesn't know whether
> we have a character or block device. __bdevname is a bit better because
> it's block-device specific. It's not perfect yet, though.
And the actual important information is missing in this mail (I'm a bit
fast in hitting the send button today :)). The proper replacement for
kdevname on blockdevices would be partitions_name - but in this specific
case we can't use it because it's the piece of code that constructs the
name that is stored for use by partition_name if we don't have any
better information.
prev parent reply other threads:[~2003-03-01 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-01 18:03 [PATCH] die kdevname(), die! Christoph Hellwig
2003-03-01 18:10 ` Linus Torvalds
2003-03-01 18:14 ` Christoph Hellwig
2003-03-01 18:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030301192038.A2248@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox