From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 1 Mar 2003 13:10:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 1 Mar 2003 13:10:23 -0500 Received: from verein.lst.de ([212.34.181.86]:13068 "EHLO verein.lst.de") by vger.kernel.org with ESMTP id ; Sat, 1 Mar 2003 13:10:23 -0500 Date: Sat, 1 Mar 2003 19:20:38 +0100 From: Christoph Hellwig To: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] die kdevname(), die! Message-ID: <20030301192038.A2248@lst.de> Mail-Followup-To: Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org References: <20030301190355.A1900@lst.de> <20030301191441.A2185@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20030301191441.A2185@lst.de>; from hch@lst.de on Sat, Mar 01, 2003 at 07:14:41PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 01, 2003 at 07:14:41PM +0100, Christoph Hellwig wrote: > On Sat, Mar 01, 2003 at 10:10:23AM -0800, Linus Torvalds wrote: > > > > I really think that replacing "kdevname()" with "__bdevname()" is a step > > in the wrong direction (or at least sideways). > > kdevname() is the really wrong interface because it doesn't know whether > we have a character or block device. __bdevname is a bit better because > it's block-device specific. It's not perfect yet, though. And the actual important information is missing in this mail (I'm a bit fast in hitting the send button today :)). The proper replacement for kdevname on blockdevices would be partitions_name - but in this specific case we can't use it because it's the piece of code that constructs the name that is stored for use by partition_name if we don't have any better information.