From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, pcihpd-discuss@lists.sourceforge.net
Subject: Re: [BK PATCH] PCI hotplug changes for 2.5.63
Date: Sat, 1 Mar 2003 14:25:33 -0800 [thread overview]
Message-ID: <20030301222533.GC1975@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0303011357130.2079-100000@home.transmeta.com>
On Sat, Mar 01, 2003 at 02:00:58PM -0800, Linus Torvalds wrote:
>
> On Sat, 1 Mar 2003, Greg KH wrote:
> >
> > It looks right to me, but I don't have a working cardbus machine at the
> > moment, so I can't test it, sorry.
>
> I don't think this is right. When we unplug a device, we're unplugging it
> whether it is unused or not, and pci_remove_device_safe() is the wrong
> thing. It should use the "remove_behind_bridge()" thing, so I think
> Russell's patch is closer to working, but that one looked like it will
> certainly corrupt memory with any multi-function device, so I really would
> want to see something that has actually been tested too.
Fair enough, I'll try to get my laptop up and running this evening and
test these changes out on it.
thanks,
greg k-h
prev parent reply other threads:[~2003-03-01 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 1:13 [BK PATCH] PCI hotplug changes for 2.5.63 Greg KH
2003-02-25 1:15 ` [PATCH] " Greg KH
2003-02-25 1:15 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-25 1:16 ` Greg KH
2003-02-28 23:59 ` [BK PATCH] " Greg KH
2003-03-01 18:55 ` Linus Torvalds
2003-03-01 21:38 ` Greg KH
2003-03-01 22:00 ` Linus Torvalds
2003-03-01 22:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030301222533.GC1975@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox