From: Arnd Bergmann <arnd@arndb.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reduce large stack usage
Date: Sun, 2 Mar 2003 18:07:53 +0100 [thread overview]
Message-ID: <200303021807.54284.arnd@arndb.de> (raw)
In-Reply-To: <3E6222A7.9030705@colorfullife.com>
On Sunday 02 March 2003 16:26, Manfred Spraul wrote:
> What do you mean with broken? On i386, the function needs 32 byte stack
> + the space for register saving.
> It must be either a gcc bug, or a bug in your detection script - I don't
> see anything special in twofish_setkey.
You are right that the code itself is not broken -- I did not read it
properly at first. The stack frame gets small if I compile for s390x
with -fno-schedule-insn, so I suppose that optimization does
not work to well on this particular code. I'll try a different compiler
tomorrow.
I can verify the 32 bytes on i386 with both gcc-3.2 and gcc-3.3-snapshot.
However, when compiling i386 twofish with gcc-2.95, I get an 804 bytes
stack frame. Other architectures are probably somewhere in between
i386 and s390x here, so there should be done something about this.
Arnd <><
next prev parent reply other threads:[~2003-03-02 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-02 15:26 [PATCH] reduce large stack usage Manfred Spraul
2003-03-02 17:07 ` Arnd Bergmann [this message]
[not found] <20030301071007$18ea@gated-at.bofh.it>
2003-03-02 14:11 ` Arnd Bergmann
2003-03-02 15:38 ` Anders Gustafsson
2003-03-02 17:14 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2003-03-01 7:06 Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303021807.54284.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox