public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: 2.5.63: 'Debug: sleeping function called from illegal context
Date: Sun, 2 Mar 2003 19:13:01 +0000	[thread overview]
Message-ID: <20030302191300.B10914@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3E62200D.2010505@colorfullife.com>; from manfred@colorfullife.com on Sun, Mar 02, 2003 at 04:15:25PM +0100

On Sun, Mar 02, 2003 at 04:15:25PM +0100, Manfred Spraul wrote:
> I would propose something like the attached patch - it handles all archs 
> that support disable_irq on an unregistered interrupt. The remaining 
> arch [which one, btw] must implement request_irq_disabled().
>...
> +{
> +	int retval;
> +	disable_irq(irq);
> +	retval = request_irq(irq, handler, irqflags, devname, dev_id);
> +	if (retval < 0)
> +		enable_irq(irq);
> +	return retval;
> +}
> +#endif

request_irq() explicitly enables the interrupt source no matter how many
times you call disable_irq() before hand.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  reply	other threads:[~2003-03-02 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-02 15:15 2.5.63: 'Debug: sleeping function called from illegal context Manfred Spraul
2003-03-02 19:13 ` Russell King [this message]
2003-03-02 22:37 ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2003-03-02 10:23 Manfred Spraul
2003-03-02 21:54 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030302191300.B10914@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox