* [PATCH] Another bitop on boolean in pnpbios
@ 2003-03-03 5:42 John Levon
2003-03-03 9:56 ` William Lee Irwin III
0 siblings, 1 reply; 3+ messages in thread
From: John Levon @ 2003-03-03 5:42 UTC (permalink / raw)
To: linux-kernel, ambx1
First obvious case from -Wbitop-boolean
Not tested ...
regards,
john
--- linux-linus/include/linux/pnpbios.h 2003-01-13 22:43:41.000000000 +0000
+++ linux/include/linux/pnpbios.h 2003-03-03 05:46:42.000000000 +0000
@@ -86,7 +86,7 @@
#define PNPBIOS_DOCK 0x0020
#define PNPBIOS_REMOVABLE 0x0040
#define pnpbios_is_static(x) ((x)->flags & 0x0100) == 0x0000
-#define pnpbios_is_dynamic(x) (x)->flags & 0x0080
+#define pnpbios_is_dynamic(x) ((x)->flags & 0x0080)
/* 0x8000 through 0xffff are OEM defined */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Another bitop on boolean in pnpbios
2003-03-03 5:42 [PATCH] Another bitop on boolean in pnpbios John Levon
@ 2003-03-03 9:56 ` William Lee Irwin III
2003-03-03 20:25 ` John Levon
0 siblings, 1 reply; 3+ messages in thread
From: William Lee Irwin III @ 2003-03-03 9:56 UTC (permalink / raw)
To: John Levon; +Cc: linux-kernel, ambx1
On Mon, Mar 03, 2003 at 05:42:35AM +0000, John Levon wrote:
> #define pnpbios_is_static(x) ((x)->flags & 0x0100) == 0x0000
> -#define pnpbios_is_dynamic(x) (x)->flags & 0x0080
> +#define pnpbios_is_dynamic(x) ((x)->flags & 0x0080)
pnpbios_is_static() could probably use the same treatment.
-- wli
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Another bitop on boolean in pnpbios
2003-03-03 9:56 ` William Lee Irwin III
@ 2003-03-03 20:25 ` John Levon
0 siblings, 0 replies; 3+ messages in thread
From: John Levon @ 2003-03-03 20:25 UTC (permalink / raw)
To: William Lee Irwin III, linux-kernel, ambx1; +Cc: torvalds
On Mon, Mar 03, 2003 at 01:56:43AM -0800, William Lee Irwin III wrote:
> pnpbios_is_static() could probably use the same treatment.
Sure. Linus, at least one of the below actually broke...
regards
john
--- linux-linus/include/linux/pnpbios.h 2003-01-13 22:43:41.000000000 +0000
+++ linux/include/linux/pnpbios.h 2003-03-03 20:28:43.000000000 +0000
@@ -85,8 +85,8 @@
#define PNPBIOS_BOOTABLE 0x0010
#define PNPBIOS_DOCK 0x0020
#define PNPBIOS_REMOVABLE 0x0040
-#define pnpbios_is_static(x) ((x)->flags & 0x0100) == 0x0000
-#define pnpbios_is_dynamic(x) (x)->flags & 0x0080
+#define pnpbios_is_static(x) (((x)->flags & 0x0100) == 0x0000)
+#define pnpbios_is_dynamic(x) ((x)->flags & 0x0080)
/* 0x8000 through 0xffff are OEM defined */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-03-03 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-03 5:42 [PATCH] Another bitop on boolean in pnpbios John Levon
2003-03-03 9:56 ` William Lee Irwin III
2003-03-03 20:25 ` John Levon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox