public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Nicholas Wourms <nwourms@netscape.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Incorrect 80 wire detection with amd 760mpx & 2.4.21-pre4-ac7
Date: Mon, 3 Mar 2003 16:44:24 +0100	[thread overview]
Message-ID: <20030303164424.A6078@ucw.cz> (raw)
In-Reply-To: <1046571368.24901.2.camel@irongate.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Sun, Mar 02, 2003 at 02:16:08AM +0000

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Sun, Mar 02, 2003 at 02:16:08AM +0000, Alan Cox wrote:
> On Sun, 2003-03-02 at 00:54, Nicholas Wourms wrote:
> > FYI:
> > I suspect that: 
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=104619727013220&w=2
> > is related to my problem.
> > 
> > Anyhow, I'm using a UDMA5 WesternDigital drive on a ASUS 
> > K7M266-D motherboard.  With a plain, stock 2.4.20 kernel, 
> > the viper driver properly recognizes which channel has the 
> 
> Yep. I'll apply the obvious fix if Vojtech doesn't. Its on the known
> list

Obvious fix attached.

-- 
Vojtech Pavlik
SuSE Labs

[-- Attachment #2: obvious-fix.diff --]
[-- Type: text/plain, Size: 1082 bytes --]

--- linux-2.4.20-pre4-ac/drivers/ide/pci/amd74xx.c	Fri Feb 28 17:05:25 2003
+++ linux-2.4.20-pre4-amd8111/drivers/ide/pci/amd74xx.c	Fri Feb 28 17:19:37 2003
@@ -1,5 +1,5 @@
 /*
- * Version 2.9
+ * Version 2.10
  *
  * AMD 755/756/766/8111 and nVidia nForce IDE driver for Linux.
  *
@@ -103,7 +103,7 @@
 
 	amd_print("----------AMD BusMastering IDE Configuration----------------");
 
-	amd_print("Driver Version:                     2.9");
+	amd_print("Driver Version:                     2.10");
 	amd_print("South Bridge:                       %s", bmide_dev->name);
 
 	pci_read_config_byte(dev, PCI_REVISION_ID, &t);
@@ -309,7 +309,8 @@
 
 		case AMD_UDMA_100:
 			pci_read_config_byte(dev, AMD_CABLE_DETECT, &t);
-			amd_80w = ((u & 0x3) ? 1 : 0) | ((u & 0xc) ? 2 : 0);
+			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
+			amd_80w = ((t & 0x3) ? 1 : 0) | ((t & 0xc) ? 2 : 0);
 			for (i = 24; i >= 0; i -= 8)
 				if (((u >> i) & 4) && !(amd_80w & (1 << (1 - (i >> 4))))) {
 					printk(KERN_WARNING "AMD_IDE: Bios didn't set cable bits corectly. Enabling workaround.\n");

      reply	other threads:[~2003-03-03 15:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-02  0:54 Incorrect 80 wire detection with amd 760mpx & 2.4.21-pre4-ac7 Nicholas Wourms
2003-03-02  2:16 ` Alan Cox
2003-03-03 15:44   ` Vojtech Pavlik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030303164424.A6078@ucw.cz \
    --to=vojtech@suse.cz \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nwourms@netscape.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox