public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: William Lee Irwin III <wli@holomorphy.com>,
	linux-kernel@vger.kernel.org, ambx1@neo.rr.com
Cc: torvalds@transmeta.com
Subject: Re: [PATCH] Another bitop on boolean in pnpbios
Date: Mon, 3 Mar 2003 20:25:34 +0000	[thread overview]
Message-ID: <20030303202534.GA24517@compsoc.man.ac.uk> (raw)
In-Reply-To: <20030303095643.GO1195@holomorphy.com>

On Mon, Mar 03, 2003 at 01:56:43AM -0800, William Lee Irwin III wrote:

> pnpbios_is_static() could probably use the same treatment.

Sure. Linus, at least one  of the below actually broke...

regards
john

--- linux-linus/include/linux/pnpbios.h	2003-01-13 22:43:41.000000000 +0000
+++ linux/include/linux/pnpbios.h	2003-03-03 20:28:43.000000000 +0000
@@ -85,8 +85,8 @@
 #define PNPBIOS_BOOTABLE		0x0010
 #define PNPBIOS_DOCK			0x0020
 #define PNPBIOS_REMOVABLE		0x0040
-#define pnpbios_is_static(x) ((x)->flags & 0x0100) == 0x0000
-#define pnpbios_is_dynamic(x) (x)->flags & 0x0080
+#define pnpbios_is_static(x) (((x)->flags & 0x0100) == 0x0000)
+#define pnpbios_is_dynamic(x) ((x)->flags & 0x0080)
 
 /* 0x8000 through 0xffff are OEM defined */
 

      reply	other threads:[~2003-03-03 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-03  5:42 [PATCH] Another bitop on boolean in pnpbios John Levon
2003-03-03  9:56 ` William Lee Irwin III
2003-03-03 20:25   ` John Levon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030303202534.GA24517@compsoc.man.ac.uk \
    --to=levon@movementarian.org \
    --cc=ambx1@neo.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox