From: Sam Ravnborg <sam@ravnborg.org>
To: J@ravnborg.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add checkstack Makefile target
Date: Tue, 4 Mar 2003 20:08:54 +0100 [thread overview]
Message-ID: <20030304190854.GA1917@mars.ravnborg.org> (raw)
In-Reply-To: <20030304105739.GD6583@wohnheim.fh-wedel.de>
On Tue, Mar 04, 2003 at 11:57:39AM +0100, J??rn Engel wrote:
A few comments to the Makefile changes..
> diff -Naur linux-2.5.63/arch/i386/Makefile linux-2.5.63-checkstack/arch/i386/Makefile
> --- linux-2.5.63/arch/i386/Makefile Mon Feb 24 20:05:15 2003
> +++ linux-2.5.63-checkstack/arch/i386/Makefile Tue Mar 4 11:51:11 2003
> @@ -124,3 +124,12 @@
> echo ' install to $$(INSTALL_PATH) and run lilo'
> endef
>
> +CLEAN_FILES += $(TOPDIR)/scripts/checkstack_i386.pl
Do not use TOPDIR.
> +CLEAN_FILES += scripts/checkstack_i386.pl
Is preferred.
> +
> +$(TOPDIR)/scripts/checkstack_i386.pl: $(TOPDIR)/scripts/checkstack.pl
> + (cd $(TOPDIR)/scripts/ && ln -s checkstack.pl checkstack_i386.pl)
There is no need to use the symlink trick.
Just pass the architecture as first mandatory parameter.
Something like
checkstack: vmlinux FORCE
$(OBJDUMP) -d vmlinux | scripts/checkstack.pl $(ARCH)
Note that I skipped grep. Perl is good at regular expressions, and
the perl scripts already know the architecture so you can do the job there.
Since the above is now architecture independent, better locate it in
the top level Makefile.
Sam
next prev parent reply other threads:[~2003-03-04 18:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 21:16 [PATCH] add checkstack Makefile target Jörn Engel
2003-03-04 7:03 ` Muli Ben-Yehuda
2003-03-04 7:24 ` Jörn Engel
2003-03-04 10:21 ` Jörn Engel
2003-03-04 10:57 ` Jörn Engel
2003-03-04 19:08 ` Sam Ravnborg [this message]
2003-03-05 14:51 ` Jörn Engel
2003-03-05 17:14 ` Jörn Engel
2003-03-05 19:15 ` Sam Ravnborg
2003-03-05 19:54 ` Jörn Engel
2003-03-11 15:36 ` =?unknown-8bit?Q?J=F6rn?= Engel
2003-03-23 19:08 ` Sam Ravnborg
2003-03-25 13:49 ` Jörn Engel
2003-03-25 23:53 ` Juan Quintela
[not found] <20030305172012$3eb0@gated-at.bofh.it>
[not found] ` <20030305172012$0dea@gated-at.bofh.it>
[not found] ` <20030305172012$0ad6@gated-at.bofh.it>
[not found] ` <20030305172012$4a05@gated-at.bofh.it>
[not found] ` <20030305172012$03b3@gated-at.bofh.it>
[not found] ` <20030305172012$525f@gated-at.bofh.it>
[not found] ` <20030305172012$698e@gated-at.bofh.it>
[not found] ` <20030305172012$38f6@gated-at.bofh.it>
2003-03-06 1:50 ` Arnd Bergmann
2003-03-06 10:51 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030304190854.GA1917@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=J@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox