Re: [PATCH] move SWAP option in menu

[Gabriel Paubert <paubert@iram.es>]

On Tue, Mar 04, 2003 at 08:36:13PM -0800, Randy.Dunlap wrote:
> Hi,
> 
> Please apply this patch (option B of 2 choices) from
> Tomas Szepe to move the SWAP option into the General Setup
> menu.
> 
> Patch is to 2.5.64.
> 
> Thanks,
> ~Randy
> diff -urN a/arch/i386/Kconfig b/arch/i386/Kconfig
> --- a/arch/i386/Kconfig	2003-03-03 20:04:08.000000000 +0100
> +++ b/arch/i386/Kconfig	2003-03-03 19:58:48.000000000 +0100
> @@ -18,15 +18,6 @@
>  	bool
>  	default y
>  
> -config SWAP
> -	bool "Support for paging of anonymous memory"
> -	default y
> -	help
> -	  This option allows you to choose whether you want to have support
> -	  for socalled swap devices or swap files in your kernel that are
> -	  used to provide more virtual memory than the actual RAM present
> -	  in your computer.  If unusre say Y.
> -
>  config SBUS
>  	bool
>  
> diff -urN a/init/Kconfig b/init/Kconfig
> --- a/init/Kconfig	2003-02-11 01:09:48.000000000 +0100
> +++ b/init/Kconfig	2003-03-03 20:02:11.000000000 +0100
> @@ -34,9 +34,18 @@
>  
>  endmenu
>  
> -
>  menu "General setup"
>  
> +config SWAP
> +	depends on X86

Why restrict it to Intel only? I don't know if it works properly on
other architectures, but at least it would give people the opportunity 
to test it on embedded PPC/Arm/MIPS/CRIS/whatever.

>From a quick grep over a recent BK tree, the only files who have 
sections conditional on CONFIG_SWAP are:

include/linux/page-flags.h
include/linux/swap.h
mm/vmscan.c
mm/Makefile

no architecture specific code at all. From a quick look, the
conditionals are rather simple (most of them are replacements of
actual functions by dummies) and should work on all architectures.
Please let people test it on non-X86, after all it's still a 
development kernel. Any breakage is unlikely to be serious and 
embedded people are going to be the most interested since it 
saves some space.

	Gabriel