Re: 2.5.63/64 do not boot: loop in scsi_error

Mike Anderson
2003-03-06T18:02:01Z

Zwane Mwaikambo [zwane@linuxpower.ca] wrote:
> On Thu, 6 Mar 2003, James Bottomley wrote:
>
> > Actually, all three if's need nots in front:
> >
> > diff -Nru a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > --- a/drivers/scsi/scsi_error.c Thu Mar 6 11:21:22 2003
> > +++ b/drivers/scsi/scsi_error.c Thu Mar 6 11:21:22 2003
> > @@ -1490,9 +1490,9 @@
> > struct list_head *work_q,
> > struct list_head *done_q)
> > {
> > - if (scsi_eh_bus_device_reset(shost, work_q, done_q))
> > - if (scsi_eh_bus_reset(shost, work_q, done_q))
> > - if (scsi_eh_host_reset(work_q, done_q))
> > + if (!scsi_eh_bus_device_reset(shost, work_q, done_q))
> > + if (!scsi_eh_bus_reset(shost, work_q, done_q))
> > + if (!scsi_eh_host_reset(work_q, done_q))
> > scsi_eh_offline_sdevs(work_q, done_q);
> > }
>
> Ok patched 2.5.63 is back to booting as 2.5.62, would you like any more
> information?
>

I believe we have all the information we need.

Thanks for sending the previous data and trying the patch.

I still need to understand the error signature for Andries as it sounds
different then what you are seeing.

-andmike
--
Michael Anderson
andmike@us.ibm.com